[FIX] Apply Ruff fixes to berqsherm.py. - #1278
Merged
Merged
Conversation
Pyright Type CompletenessView the full Project (full
Other symbols referenced but not exported by
Symbols without documentation:
Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1278 +/- ##
=======================================
Coverage 91.68% 91.68%
=======================================
Files 93 93
Lines 5447 5447
Branches 704 704
=======================================
Hits 4994 4994
Misses 328 328
Partials 125 125
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
henrydingliu
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Knocking out
chainladder/adjustments/berqsherm.pyfrom the Ruff list. Yeah...we got a long way to go. I tried getting started on bootstrap.py but stopped when the linter was uncovering bugs.Related GitHub Issue(s)
#1216
Additional Context for Reviewers
Checklist
uv run pytest) and documentation changes (uv run --directory docs jb build . --builder=custom --custom-builder=doctest)Note
Low Risk
Lint-only edits to Berquist–Sherman adjustment code with no intended behavioral change.
Overview
Brings
chainladder/adjustments/berqsherm.pyinto compliance with the project Ruff rules so it no longer needs a per-file ignore entry inpyproject.toml.Changes are formatting and docstring style only: operator spacing in the exponential regression denominator, whitespace in
np.clip, and clearer line breaks around the nestedxp.concatenatebatching foraandb. Thetransformdocstring is normalized to a standard multi-line form (no logic change infitortransform).Reviewed by Cursor Bugbot for commit 660ab7e. Bugbot is set up for automated code reviews on this repo. Configure here.