[FIX] Apply Ruff fixes to core files. - #1287
Merged
Merged
Conversation
Pyright Type CompletenessView the full Project (full
Other symbols referenced but not exported by
Symbols without documentation:
Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1287 +/- ##
==========================================
- Coverage 91.68% 91.68% -0.01%
==========================================
Files 93 93
Lines 5447 5445 -2
Branches 704 704
==========================================
- Hits 4994 4992 -2
Misses 328 328
Partials 125 125
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
henrydingliu
reviewed
Sep 4, 2026
henrydingliu
reviewed
Sep 4, 2026
henrydingliu
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Mostly mundane formatting with the exception of one variable name change (see #1285). I left
displayuntouched as that will be addressed in #1284 and anrtestfile that needs further debugging.Related GitHub Issue(s)
#1216
Additional Context for Reviewers
Checklist
uv run pytest) and documentation changes (uv run --directory docs jb build . --builder=custom --custom-builder=doctest)Note
Low Risk
Mostly formatting and clearer naming in correlation helpers; no intended algorithm or slicing behavior changes.
Overview
Applies Ruff lint/format cleanup across
chainladder/core/correlation.py,slice.py, and related core tests, and drops the corresponding per-file ignores inpyproject.tomlnow that those files pass the rules.The only non-cosmetic code changes are in Mack correlation code: the development-period count variable
I→n_dev_periods(with a Mack-97 comment), and the inner helperpZlower→p_z_lower. Formulas and call sites are updated to use the new names; behavior should be unchanged.Tests are adjusted for style (e.g.
raa.__eq__(None)instead of== Nonefor Ruff) andtest_grain.pydrops unused imports.Reviewed by Cursor Bugbot for commit 025afa4. Bugbot is set up for automated code reviews on this repo. Configure here.