Conversation
This patch removes all handling of rdf-toolkit.jar from the CASE ontology repository. UCO had adopted CASE's rdf-toolkit retrieval in version 0.7.0, and now UCO Issue 373 will be upgrading the retrieval process. This patch handles delegation of rdf-toolkit provisioning. A follow-on patch will handle the rdf-toolkit and Java upgrade that is the focus of UCO Issue 373. References: * ucoProject/UCO#373 Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
This was referenced Jun 2, 2022
Revisions to the Java setup match UCO commit `efce5c1`. References: * ucoProject/UCO@efce5c1 * ucoProject/UCO#373 Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist
force-pushed
the
uco-issue-373
branch
from
c444981 to
1787c91
Compare
plbt5
approved these changes
Jun 3, 2022
Contributor
plbt5
left a comment
plbt5
left a comment
There was a problem hiding this comment.
In Dutch, we use the abbreviation GB when we don't find any peculiarities worth mentioning. How would that translate in English?
Member
Author
LGTM, "Looks Good To Me," is probably closest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request is part of resolving UCO Issue #373.
This PR is a little out of the normal, ontology-scoped review form, because of a shared technology issue. UCO and CASE both use
rdf-toolkit.jarto handle normalizing Turtle data. The upgrade in UCO Issue 373 will upgrade Java andrdf-toolkit.jarto a state that will be incompatible with the version of Java andrdf-toolkit.jarthat CASE has "pinned" for its CI.Hence, the patches in this PR handle two issues:
rdf-toolkit.jarretrieval.Review steps taken: