Make the symlink action idempotent, matching its advertised ln -sf semantics - #599
Open
joahg wants to merge 1 commit into
Open
Make the symlink action idempotent, matching its advertised ln -sf semantics#599joahg wants to merge 1 commit into
joahg wants to merge 1 commit into
Conversation
SymlinkAction.String() reports the action as "ln -sf", but Apply() calls os.Symlink directly, which fails with "file exists" on any subsequent run. This makes symlink actions in "on activate" triggers unusable across repeated activations without a delete workaround. Apply now follows ln -sf semantics: an existing symlink already pointing at the source is left alone, an existing symlink or regular file is replaced, and a directory at the destination is refused with an error (as ln -sf does, and to avoid destroying user data). Buzz-Message: buzz://message?channel=573ff355-6c19-422d-b425-112853d0ec7e&id=16f5b666c0976829a1985868753407c7b20b393d89f99a8b39106be9fe6a1514 Amp-Thread-ID: https://ampcode.com/threads/T-019fce27-e59e-727c-b6d3-cdeeba894a4e Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: #597 — composing agent-skills-style content packages from existing Hermit primitives.
SymlinkAction.String()reports the action asln -sf, butApply()callsos.Symlinkdirectly, which fails withfile existson any subsequent run. This makessymlinkactions inon activatetriggers unusable across repeated activations without adeleteworkaround that relies on undocumented action ordering.Applynow followsln -sfsemantics: an existing symlink already pointing at the source is left alone, an existing symlink or regular file is replaced, and a directory at the destination is refused with an error (asln -sfdoes, and to avoid destroying user data).Tested with
go test ./...andgolangci-lint run.