Skip to content

Conversation

@Xela101
Copy link

@Xela101 Xela101 commented Nov 20, 2019

New Pull Request Submissions:

  1. Have you followed the guidelines in our Contributing document?
  2. Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  3. I have added tests to cover my changes.
  4. All new and existing tests passed.
  5. Have you lint your code locally prior to submission?
  6. Does your code follows the code style of this project?
  7. Does your change require a change to the documentation.
    • I have updated the documentation accordingly.
  8. Have you added an explanation of what your changes do and why you'd like us to include them?
  9. Have you inserted a keyword and link to the issues the PR closes in its descriptions (ex closes #1) ?
  10. Is you branch up to date, have you integrated all the latest changes from develop and resolved conflicts ?
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Enhancement
  • What is the current behaviour? (You can also link to an open issue here)
    Repositories use the RepositoryWrapper
  • What is the new behaviour (if this is a feature change)?
    Repositories use their custom repository implementation and are now isolated from RestSharp, you can no longer directly query the underling RestSharp repository making it easier to test custom queries.
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    Yes, new methods have been added to the Custom repositories to isolate themselves from the underling Repository.
  • Other information:
    closes Remove repository wrapper #1108

@Xela101 Xela101 self-assigned this Nov 20, 2019
@Xela101 Xela101 added Enhancement 👷 New feature or request Pull Request 🕵️ Used for pull requests. labels Nov 21, 2019
@Xela101 Xela101 marked this pull request as ready for review November 21, 2019 18:11
@JayArrowz
Copy link
Collaborator

JayArrowz commented Nov 21, 2019

The full IRepository pattern is not exposed to the user, hence they are limited to the Repository interface methods in the Catalyst code (IPeerRepository, IMempoolRepository, etc..) instead of the actual IRepository<T, TKey> methods. (Not sure if this was the original intent)

The Repository Wrapper was exposing all the methods of the IRepository<T, TKey> this saves the developer having to write out new methods inside the interfaces (IPeerRepository, IMempoolRepository, etc..) when they are not fully exposed. And it looks like the wrapping behavior is still there, the only difference is less methods are accessible.

public PeerRepository(IRepository<Peer, string> repository)
        {
            _repository = repository;
        }

Edit: I can also see that we loose the ability to use the IQueryable pattern unless its exposed.

namespace Catalyst.Core.Lib.P2P.Repository
{
public interface IPeerRepository : IRepositoryWrapper<Peer> { }
public interface IPeerRepository
Copy link
Collaborator

@JayArrowz JayArrowz Nov 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can do it this way but then you'll need to modify this (because it is populating them inside the container using reflection and not checking if base interface is IRepository):
https://github.com/SharpRepository/SharpRepository/blob/34c910bdf480d40cf5f8ea525960d4caeaca54f6/SharpRepository.Ioc.Autofac/RepositoryRegistrationSource.cs

Suggested change
public interface IPeerRepository
public interface IPeerRepository : IRepository<Peer, string>

Only benefit from this is that you wont get IRepository<Peer, string> all over the code and you can use the IRepository functions.

Copy link
Author

@Xela101 Xela101 Nov 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I have talked with James a few days ago about it and how the Wrapper works by allowing you to use the full repository functionality and think we are going to only allow users to construct their own specific methods and limit direct querying. It should hopefully allow for better code reuse and testing. I think now these Specific Repositories could be renamed Services since it is pretty much the repository-service pattern.

@Xela101 Xela101 requested a review from nshCore November 22, 2019 11:01
@nshCore nshCore merged commit ac0add5 into develop Nov 22, 2019
@nshCore nshCore deleted the remove-repository-wrapper branch November 22, 2019 17:25
sudhirtibrewal added a commit that referenced this pull request May 4, 2020
* Delta height peer query (#1019)

* Update nuget-pre-release-azure-pipelines.yml for Azure Pipelines

* Update pr-test-suite-azure-pipelines.yml for Azure Pipelines (#1100)

* Delta index query and p2p protocols refactor

* Add attribute to daobase to map to documentdb id (#1099)

* Update error codes and descriptions. (#1105)

* Merge contract entries into public entries (#1106)

* 754 unit test config value parser (#1109)

* Add ConfigValueParser tests

* Add test on empty config

* remove unused imports

* Remove repository wrapper (#1108)

* consensus and crypto perf optimizations (#1111)

* Benchmarks added

* Non-allocating extensions added

* A few usages of ToByteArray replaced with the new extensions for hashing

* ICryptoContext got extensions to directly work on messages

* Tests amended to use the proper Verify method

* File headers

* Tests use now IMessage based overloads

* Review remarks amended.

* API span field

* KeySigner just lost two more ToByteArray

* Benchmarks amended to comply to code rules

* C# bumped up to 8.0 which allows using ref struct for scoping lifetime of serialized messages.

* docs: add Scooletz as a contributor (#1112)

* Better substitutes for spanified interfaces (#1118)

* Use PublicEntry as mempool item instead of TransactionBroadcast (#1110)

* update protocol

* Fix consensus poa test (#1122)

* Rename public key entries in public transactions to address (#1127)

* Send exists response to client if transaction exists in mempool (#1126)

* Fix codacy warnings (#1128)

* Add unit tests for json converters and turn CidHelper into Dfs Extensions (#1125)

* rebased on top of develop and squashed

* Leading space in licenses

* Substitute registered in PoaTestNode

* Derep peers that vote out of delta producers (#1132)

* StateRoot added to DeltaProto; DeltaExecutor properly configured

* LedgerModule no longer registerd EF repository explicitly, leaving the config to the SharpRepository

* StateRootResolver removed as Delta has the root now; all web3Api is done under one lock now

* Initial getStorageAt

* getTransactionCount

* Cleaning

* Receipts

* Minor tests related

* Ledger delta executions

* Fixing crypto issues with test data generator

* initial transactions

* Delta executor used

* Web3 API module now is registered with a container reuse, enabling sharing registrations

* Module work

* Components made independent from registration and KeyFilter, WithExecutionParameters added to register a custom set of registrations related to execution per component

* Missing registration in KVM added

* JSON Rpc amended to handle ids properly

* returning to ArrayPool moved to finally

* DocumentId in receipt calculated in Ledger

* TruffleTest added

* builds from Truffle no longer tracked

* PublicEntries build from transaction call WIP

* DeltaWithCid added to ease resolutions of delta with cids with extracted method of obtaining it.

* Remove redundant repository classes (#1136)

* Remove redundant repo classes

* Update rust submodule

* SendTransaction amended

* moving forward with Web3

* eth_getTransactionCount now returns 0 for nonexistent accounts

* Converters added for RPCs

* Genesis delta block augmented to include some value for a specific account

* KeccakConverter registered; GetStorageHandler now handles nonexistent storages

* Hacks to make it work

* TimeStamp type is mapped automatically

* DeltaHashProvider disinguishes different cases for deltas not being updated

* DeltaHashProvider logs enhanced + Ledger applies deltas

* local changes for debugging

* WIP more handlers

* WIP handlers separated

* TransactionsReceipts now can be found from the delta itself

* Delta has its number embedded, Cids used for RPC, a few more calls implemented

* getTransactionByHash

* CidJsonConvert introduced to map Rpc models with requirements of eth web3

* Hashing PublicEntry changed to explicitly opt-in needed properties

* TransactionFees removed from PublicEntry

* local changes for debugging

* Program amended with consts

* scripts for testing cat vs neth

* scripts for testing cat vs neth

* local changes for debugging

* Program amended with consts

* empty to address is properly handled now

* sample of truffle and nethermind conversation for the EIP20 deployment

* some fixes

* fixed things around receipts and get code

* debug messages

* keep searching

* Added logging filters and removed some diag logging

* state root to keccak, some web3 by hash fixes

* working deployment

* Refactor and fix build warnings (#1137)

* Refactor async methods and fix project warnings.

* Refactor name to omit warning.

* Add configure await to async methods.

* Update rust submodule.

* Update PR pipeline for latest agents.

* Fix windows build of rust toolchain.

Co-authored-by: nshCore <nshcore@protonmail.com>

* Update instructions and links in README (#1158)

* Create delta index service (#1160)

* Create reverse mapping of DeltaIndexDao and add DeltaIndexService

* Add license headers to delta index service files

* Update DeltaIndexDao to use converter

* Update ApiModule to prevent blocking sigint (#1163)

Co-authored-by: nshCore <nshcore@protonmail.com>

* Implement delta height request observer (#1162)

* Create reverse mapping of DeltaIndexDao and add DeltaIndexService

* Add license headers to delta index service files

* Add DeltaHistoryRequestObserver implementation from delta index

* Update unit test to use new constructor params and rearrange constructor params

* Update autofac registrations

* Update delta height response observer to use real data

* Update DeltaIndexDao to use converter

Co-authored-by: nshCore <nshcore@protonmail.com>

* Implement delta history request observer (#1161)

* Create reverse mapping of DeltaIndexDao and add DeltaIndexService

* Add license headers to delta index service files

* Add DeltaHistoryRequestObserver implementation from delta index

* Update unit test to use new constructor params and rearrange constructor params

* Update autofac registrations

* Update DeltaIndexDao to use converter

Co-authored-by: nshCore <nshcore@protonmail.com>

* Catalyst DFS  (#1138)


* Fix unit tests without strong dfs dependancy

* Use HashingModule for dfs

* Refactor Dfs WebApi

* Fix dfs unit tests

* Fix more dfs unit tests

* Fixed more tests, only 10 left

* Fix all bootstrap api tests

* Try add Ed25519 env

* Add media files to test large files in dfs

* Refactor more dfs classes

* Update file system for poa tests

* Use dfs for PoaConsensusTest

* Correct dfs directory structure

* Remove hash provider inside dfs

* Fix receiving blocks with correct hash format

* Add hash provider to add file to dfs test

* Connecting successfully to IPFS and receiving files :)

* Fix AddFile unit test

* Add license header to files

* Update rust submodule

* Update POA Concensus test to remove time barrier

* Use test scheduler for rep manager unit tests

* Remove doc gen from libp2p

* Update Libp2p props

* Update libp2p

* Update rust submodule

* Fix unit tests

* Do not generate assembly info

* Do not generate assembly info

* Quick Fix for SIGINT blocked by ApiModule

* Update dfs unit tests for CI

* Fix POA unit tests

* Refactor to use more DI

* Update POA unit test

* Increase timeout on dns dotclient

* Update unit test

* Use DnsClient instead of DotClient to test ci

* Remove libp2p unit tests and multihash as they are unchanged 3rd party and libp2p contains race condition

* Remove test files for 3rd party

* Refactor for Codeacy

* Refactor for autofac

* Update DfsModule

* Refactor for autofac

* Merge develop

* Skip Run_Conccensus intergration test as sockets are getting disposed somehow in the ci - Will fix this later but using to much time and need to move on

* Skip Run_Conccensus integration test as sockets are getting disposed of some how in the ci - Will fix this later but using to much time and need to move on

* clean up dfs controllers

Co-authored-by: nshCore <nshcore@protonmail.com>

* protocol buffers pointing at latest develop

* fix some namespaces after merge? guessing

* trying to make it build with chnges in delta hash

* some random changes in hope for a build

* clean BlockForRpc

* moved class to a separate file

* line length split

* removed unused class

* comment out hrdcoded password

* removing some compiler warnings

* some test fixe

* removed various warnings

* ordering fix

* fixed ledger tests

* test fix

* ledget tests / state root

* all tests passing

* readding shared container

* deserialization fix

* comversion / block params / addresses

* Add web3 truffle support (#1167)

* rebased on top of develop and squashed

* Leading space in licenses

* Substitute registered in PoaTestNode

* StateRoot added to DeltaProto; DeltaExecutor properly configured

* LedgerModule no longer registerd EF repository explicitly, leaving the config to the SharpRepository

* StateRootResolver removed as Delta has the root now; all web3Api is done under one lock now

* Initial getStorageAt

* getTransactionCount

* Receipts

* Minor tests related

* Ledger delta executions

* Fixing crypto issues with test data generator

* initial transactions

* Delta executor used

* Web3 API module now is registered with a container reuse, enabling sharing registrations

* Components made independent from registration and KeyFilter, WithExecutionParameters added to register a custom set of registrations related to execution per component

* Missing registration in KVM added

* JSON Rpc amended to handle ids properly

* returning to ArrayPool moved to finally

* DocumentId in receipt calculated in Ledger

* TruffleTest added

* builds from Truffle no longer tracked

* PublicEntries build from transaction call WIP

* DeltaWithCid added to ease resolutions of delta with cids with extracted method of obtaining it.

* SendTransaction amended

* moving forward with Web3

* eth_getTransactionCount now returns 0 for nonexistent accounts

* Converters added for RPCs

* Genesis delta block augmented to include some value for a specific account

* KeccakConverter registered; GetStorageHandler now handles nonexistent storages

* Hacks to make it work

* TimeStamp type is mapped automatically

* DeltaHashProvider distinguishes different cases for deltas not being updated

* DeltaHashProvider logs enhanced + Ledger applies deltas

* TransactionsReceipts now can be found from the delta itself

* Delta has its number embedded, Cids used for RPC, a few more calls implemented

* getTransactionByHash

* CidJsonConvert introduced to map Rpc models with requirements of eth web3

* Hashing PublicEntry changed to explicitly opt-in needed properties

* TransactionFees removed from PublicEntry

* scripts for testing cat vs neth

* local changes for debugging

* Program amended with consts

* empty to address is properly handled now

* sample of truffle and nethermind conversation for the EIP20 deployment

* Added logging filters and removed some diag logging

* state root to keccak, some web3 by hash fixes

* working deployment

* protocol buffers pointing at latest develop

* clean BlockForRpc

* ledget tests / state root

* Apply suggestions from code review

Co-authored-by: Szymon Kulec <scooletz@gmail.com>
Co-authored-by: nshCore <nshcore@protonmail.com>

* old style with ECDSA

* additional account

* catalyst provider package

* sig validation working fine

* batch requests handler

* test fix

* adds sig verifier and hashing precompiles to KVM

* build fix

* this deserves some tests

* fixed error results for Ed25519 and returned value is bool now (#1173)

Co-authored-by: sudhirtibrewal <sudhirtibrewal@gmail.com>

* Test change to PR test trigger (#1194)

* Batch verification (#1186)

Adds functionality for batch verification of signatures

* Fix pr test triggers (#1198)

* Update native library to remove warning message when node starts (#1202)

* Sync, + Eth Json RPC and other changes for TestNet (#1179)

* Use dfs for PoaConsensusTest

* Correct dfs directory structure

* Remove hash provider inside dfs

* Fix receiving blocks with correct hash format

* Add hash provider to add file to dfs test

* Connecting successfully to IPFS and receiving files :)

* Fix AddFile unit test

* Add license header to files

* Update rust submodule

* Update POA Concensus test to remove time barrier

* Use test scheduler for rep manager unit tests

* Remove doc gen from libp2p

* Update Libp2p props

* Update libp2p

* Update rust submodule

* WIP

* WIP

* WIP

* WIP

* WIP

* WIP

* Fix unit tests

* Do not generate assembly info

* Do not generate assembly info

* Quick Fix for SIGINT blocked by ApiModule

* Update dfs unit tests for CI

* Test CI

* Starting of Sync ;)

* Core classes for Sync

* Add unit test to continue sync from previous delta index

* Add unit test signatures to SyncUnitTests

* Add more unit test signatures

* Remove race condition from Wants and UnWants unit tests

* Add more functionality to sync

* Update for CI

* Update yml files for CI

* Update yml files for CI

* Update yml files for CI

* Remove dfs tests to test ci

* Revert sln

* CI Test

* CI Test

* CI Test

* CI Test

* CI Test

* CI Test

* CI Test

* CI Test

* CI Test

* CI Test

* CI Test

* CI Test

* Update POA unit test

* Update TestDfs stub

* Refactor dfs

* Fix unit tests

* Fix POA unit tests

* Refactor to use more DI

* Update POA unit test

* Increase timeout on dns dotclient

* Update unit test

* Use DnsClient instead of DotClient to test ci

* Remove libp2p unit tests and multihash as they are unchanged 3rd party and libp2p contains race condition

* Remove test files for 3rd party

* Refactor for Codeacy

* Add debug info to response of poa consensus test

* Add debug info to response of poa consensus test

* Refactor for autofac

* Update DfsModule

* Refactor for autofac

* Merge develop

* Skip unit tests

* Add debugging info

* Add debugging info

* Add debugging info

* Remove debug info

* Debug info

* Skip Run_Conccensus intergration test as sockets are getting disposed some how in the ci - Will fix this later but using to much time and need to move on

* Skip Run_Conccensus intergration test as sockets are getting disposed some how in the ci - Will fix this later but using to much time and need to move on

* Codacy fixes

* WIP

* Update  yaml files for pipeline

* Update yaml pipeline

* Codacy issues

* clean up dfs controllers

* Update unit tests

* Sync unit test

* Add more unit tests to sync

* codacy

* Refactor code into seperate classes

* Update sync unit tests

* Update sync

* Use three nodes in intergration test

* Apply suggestions from code review

* Refactor ranking logic

* Remove comments

* Update delta height watcher

* Update serilog

* Update wait peer

* Update to test sync

* Test on multi-node

* Test on multi-node

* Check timestamp between nodes

* Fix date time issue

* Small update for remote node testing

* Add debug info for height

* Add debug info for height

* Add debug info for height

* Increase challenge count peer

* Forign PingRequests are added to PeerRepo for PoaDiscovery, Sync updates - MongoDb

* comments from discussion

* Migrate changes from truffle branch

* Update sync

* Fix some unit tests and remove dfs blacklisting

* Update ethcontroller for stephen

* Comment out validation in delta

* Update byteextensions to use dag instead of raw

* Update ContentType of cid

* Update bootstrap nodes

* Add eth sync and peer count calls

* Merge LedgerSync into Sync

* Merge LedgerSync into Sync

* Fix cachebetween

* Add json rpc calls for chain id and pending transactions

* Use peer count from dfs

* Turn off blacklisting in ipfs

* Refactor sync

* Rename sync files and set minimum peers for network to 3

* Revert max ping count limit

* Change peer count to two

* Revert max ping count limit

* Add more users to configs

* Add myself

* Update inactive for to test concensus

* DI min peer count and null reference exception temp fix

* Fix unit tests

* only known authority nodes can produce a delta

* Update sync unit tests

* Update add fields to Peer: IsSync, Height and IsPoaNode

* Update poa unit test

* Update submodule

* Revert is sync in PeerRepo ActivePoaNodes

* Update CandidateDeltaObserver

* Test ping system

* Increase ping speed

* Revsert POA peer call

* PingRequest update

* Don't remove peer from counter

* Slow down ping

* Update peer id in sync

* Remove if statement

* Add more sync blocks

* Test

* Awol

* Add issync

* Remove self from broadcast

* Add self

* Test

* Update only allow POA Nodes in producer pool

* Derep

* Remove data from pingresponse

* Revert protocol

* Update ping tests

* Update hashing from Blake2b to keccak

* Fix intergration tests

* fixed error results for Ed25519 and returned value is bool now

* Remove Messenger classes and use PeerClient instead

* Fix dfs delta downloader

* Resolve conflicts

* Persistant state

* Remove Rocks IRepo

* Fix transaction with persistant state

* Add updates to sync

* Update directory delete to include files

* Add check to see if dir exists

* Fix to sync issue

* Also skip empty di's ;)

* Update poa nodes

* Make range smaller

* Null reference fix

* Reset back to 20 min for range

* Test faster cycle

* Reduce content router timespan

* Turn off mdns

* Test 1 second block time

* Revert

* Update timings

* Delete mempool items

* Disable mdns

* Updates to lib p2p and discovery

* use im memory for mempool

* update events provider and concensus

* Only evict non poa nodes

* Update intergration tests

* Add classes for StateResetter

* Update kernel

* fix for #1187

* Add protocol changes

* Update unit test

* Sync update

* Add delay to concensus

* sync update

* Add GasUsed

* Update code to match proto updates

* update submodule and add node to list of authority nodes

* Update protocol submodule

* Update peer black list to match proto

* Use public address for peer id not bind address

* use state memory

* Remove non poa node from list

* Update some test fixtures and models

* Update sln

* update rust submodule

* Update sln

* Revert Uint256 extensions tests

* Use persistance for kvm state

* Refactor

* Jk documentation (#1203)

* Merge documentation fork into main repo (#1192)

* Update

* Add more instructions

* Add config poa node

* Update README.md

* Update README.md

* Update README.md

* Update Security.md

* Update Readme

* Add Contributor

* Update

* Update

* update

* Update

* Update

* Add website link

* Add documentation

* Refactor delta height watcher

* Add Install Nightly instructions

Additional doculmentation on how to install and enable nightly mode for rust

* Update pipeline

* Comment out test that is not used

* Remove unused test

* Change PoaTestNode Registrations

Co-authored-by: nshcore <nshcore@protonmail.com>
Co-authored-by: Sudhir Tibrewal <s.tibrewal@reply.eu>
Co-authored-by: Tomasz Kajetan Stanczak <tkstanczak@users.noreply.github.com>
Co-authored-by: fran <fran.sl@atlascity.io>
Co-authored-by: Joseph Kearney <46780513+kearneyjj1@users.noreply.github.com>
Co-authored-by: Joseph Kearney <kearneyjj@outlook.com>

* Document update (#1207)

* Update instructions on running a node

* Update TOC

* Check if delta/candidate/fav came from POA node in more places. (#1213)

* Check if delta was from POA node in more places

* Check if delta was from POA node in more places

* Update nethermind upstream unit tests (#1211)

* 3.1 LTS + submodule fixing

* adding new projects from neth

* upgrade packages

* updating namespaces

* tests 16.5.0

* test adapter versions updated

* downgraded tests to 16.4.0

* Converting from XUnit to NUnit

* Fix Update more tests more tests

* Fix Update more tests more tests

* Fix Update more tests more tests

* Fix more tests

* Add changes to DB

Branch now working

* edit imports

* Fix more unit tests

* Fix more unit tests

* Fix more unit tests

* Fix more unit tests

* Fix more unit tests

* Fix more unit tests

* Fix more unit tests

* Fix more unit tests

* getting tests runner

* fixed KVM errors in test

* Update Hashing project

* Fix more tests

* Fix more tests

* Update pipeline dotnet core sdk version

* Fix more tests

* Fix pipeline test

* Increase prox state cycle sync

* Increase prox state cycle sync

* Refactor tests

* Test pipeline

* Test pipeline

* Skip poa concensus

Co-authored-by: Tomasz Kajetan Stanczak <tkstanczak@users.noreply.github.com>
Co-authored-by: Joseph Kearney <kearneyjj@outlook.com>
Co-authored-by: fran <fran.sl@atlascity.io>

* Substitute peer repo for CandidateDeltaObserver and FavouriteDeltaObserver tests (#1214)

* Update file system api tests to use nunit setup instead of constructor (#1220)

* Fix sync issue with DeltaHashProvider (#1221)

* Fix sync issue

* Fix edge case if genisis is already in delta index service

* Fix mempool items not removed incorrect hash, remove timestamp from transaction. (#1222)

* Fix sync issue

* Fix edge case if genisis is already in delta index service

* Remove timestamp from transaction and fix removing transaction from mempool + transaction hash

* Update protocol

* Add poa consensus test

* Comment out ignore

* Update protocol submodule

* Remove poa concensus test ignore attribute

* Fix get balance bug on reset (#1224)

* Dont use inmem

* Add native rocks

* Add rocks to core lib

* Oops use native

* Bump PeterO.Cbor from 3.1.0 to 4.0.0 in /src/Catalyst.Core.Modules.Dfs (#1197)

Bumps [PeterO.Cbor](https://github.com/peteroupc/CBOR) from 3.1.0 to 4.0.0.
- [Release notes](https://github.com/peteroupc/CBOR/releases)
- [Changelog](https://github.com/peteroupc/CBOR/blob/master/History.md)
- [Commits](peteroupc/CBOR@v3.1.0...v4.0.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alex <alex.white@atlascity.io>

* updating neth reference (#1228)

* updating neth reference

* build fixes

* Fixed disposal of containers creating rocksdb (#1233)

Co-authored-by: franssl <46971650+franssl@users.noreply.github.com>

* Fix test suite  (#1231)

* remove duplicate import

* add missing library

* test for linux

* remove pipeline step add project reference

* Refactor to move POATestNode to TestUtils

* add snappy for linux

* add snappy for mac

* add underscore to library link

* Remove redundant Dispose method

* Refactor to remove test project dependancy on DFS.Tests

* fixed disposal of containers creating rocksdb

Co-authored-by: Tomasz Kajetan Stanczak <tkstanczak@users.noreply.github.com>

* Fix test filtering (#1235)

* Update azure pipelines

Co-authored-by: nshCore <nshcore@protonmail.com>
Co-authored-by: franssl <46971650+franssl@users.noreply.github.com>
Co-authored-by: Szymon Kulec <scooletz@gmail.com>
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Tomasz Kajetan Stanczak <tkstanczak@users.noreply.github.com>
Co-authored-by: sudhirtibrewal <s.tibrewal@reply.eu>
Co-authored-by: sudhirtibrewal <sudhirtibrewal@gmail.com>
Co-authored-by: fran <fran.sl@atlascity.io>
Co-authored-by: Joseph Kearney <46780513+kearneyjj1@users.noreply.github.com>
Co-authored-by: Joseph Kearney <kearneyjj@outlook.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement 👷 New feature or request Pull Request 🕵️ Used for pull requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants