Add $0 bill output for PINs with an EAV less than $150#91
Add $0 bill output for PINs with an EAV less than $150#91kyrasturgill merged 8 commits into2024-data-updatefrom
Conversation
jeancochrane
left a comment
There was a problem hiding this comment.
Thanks so much for the quick turnaround! A couple nits and questions below, but nothing serious.
| dt[, tax_amt_pre_exe := round(eav * agency_tax_rate, 2)] | ||
| dt[, tax_amt_post_exe := round(tax_amt_pre_exe - tax_amt_exe, 2)] | ||
| dt[tax_amt_post_exe < 0, tax_amt_post_exe := 0] | ||
| dt[eav < 150, tax_amt_post_exe := 0] |
There was a problem hiding this comment.
[Question, non-blocking] Something I should have thought about earlier: Do you know if the Treasurer's $150 limit applies to the pre- or post-exemption EAV? This code will apply it to the pre-exemption EAV, which may lead tax_bill() to miss some $0 bills if the Treasurer's logic actually depends on post-exemption EAV.
There was a problem hiding this comment.
AH I can't believe I didn't think of that! I believe it is post-exemption EAV. I did a test and found that there are PINs with pre-exemption EAV over $150 but a post-exemption under that have tax_bill_total equal to $0.
Co-authored-by: Jean Cochrane <jeancochrane@users.noreply.github.com>
…data/ptaxsim into kyrasturgill/fix-eav-under-150-bug
|
Documenting for posterity - I did some QC to ensure the PINs impacted by the change to the function were those we'd expect (taxable EAV < 150). In doing a quick calc of taxable EAV of
So, this update for handling taxable eav < 150 will return $0 bill for farmland with av < 150. Turns out this rule aligns with what shows up in |
This PR adds an exception to the
tax_bill()function, defaulting the tax bill amount to zero when a PIN's final EAV is less than $150, mirroring the Treasurer which does not send tax bills to PINs with an EAV that is less than $150 and ultimately records the bill as $0. This ensures alignment between thefinal_taxoutput of thetax_bill()function and thetax_bill_totalfield which mirrors the final bill amount from the Treasurer's data.