Skip to content

Harden the pyvolca converter example - #203

Merged
ccomb merged 1 commit into
mainfrom
fix/converter-local-source-config
Jul 14, 2026
Merged

Harden the pyvolca converter example#203
ccomb merged 1 commit into
mainfrom
fix/converter-local-source-config

Conversation

@ccomb

@ccomb ccomb commented Jul 14, 2026

Copy link
Copy Markdown
Owner

Summary

  • copy the source into the temporary run directory and declare it in volca.toml instead of uploading it over a raceable loopback port
  • remove explicit unload/delete cleanup that could mask the primary conversion failure; server shutdown and temporary-directory cleanup now own the lifecycle
  • narrow the pyvolca 0.8.0 HTTP 406 fallback and retain warning propagation
  • add behavioral coverage for fallback matching and warnings

Verification

  • uv run --with-editable . --with pytest pytest -q — 226 passed, 7 skipped
  • uv run --with-editable . --with pyright==1.1.411 pyright — clean
  • real pyvolca 0.8.0 / VoLCA 0.9.1 run produced valid ILCD, EcoSpold 1, and EcoSpold 2 outputs

@ccomb
ccomb merged commit 5b422c5 into main Jul 14, 2026
11 checks passed
@ccomb
ccomb deleted the fix/converter-local-source-config branch July 14, 2026 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant