feat(cache): Lookup Cache Phase 2 — 多庫、SelectList、全域 TenantIsolation (Closes #142)#144
Merged
cct08311github merged 1 commit intodotnet8from Mar 10, 2026
Merged
Conversation
…bal TenantIsolation, helper methods (Closes #142) - Change GetAll/GetAllAsync return type from List<T> to IReadOnlyList<T> to prevent accidental cache mutation - Add ConnectionKey property to [CacheLookup] for multi-database support (e.g. ORSS read-only DB) - Change TenantIsolation to three-state (unset/true/false) with global default via LookupCacheOptions - Add GetLookupItem<T> for single-item lookup by predicate - Add GetLookupSelectList<T> for dropdown integration (ComboSelectListItem) - Add GetAttribute and DefaultTenantIsolation to ILookupCacheService - Update CacheLookupAttribute remarks to reference FrameworkContext.SaveChanges - Update docs with new features, stampede protection note, filter semantics, EmptyContext caveat - Add 7 new tests covering IReadOnlyList, GetAttribute, DefaultTenantIsolation, ConnectionKey Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2 improvements based on BMS production integration feedback:
[CacheLookup(ConnectionKey = "orss")]) for models in secondary databasesDefaultTenantIsolation = falseonce instead of per-modelComboSelectListItemCloses #142
Test plan
🤖 Generated with Claude Code