Skip to content

Tests: move proxy to skip-tests.json [ci skip]#17823

Merged
kroitor merged 4 commits into
ccxt:masterfrom
carlosmiei:move-proxy
May 8, 2023
Merged

Tests: move proxy to skip-tests.json [ci skip]#17823
kroitor merged 4 commits into
ccxt:masterfrom
carlosmiei:move-proxy

Conversation

@carlosmiei

Copy link
Copy Markdown
Collaborator

No description provided.

@ttodua

ttodua commented May 7, 2023

Copy link
Copy Markdown
Member

looks good 👍

@ttodua

ttodua commented May 7, 2023

Copy link
Copy Markdown
Member

additionally, I had a thought that in keys.json we might add one sample entry, like:

{
    "xyzexchange" : {
        "httpProxy": "012.345.678.910"
        "apiKey": "xxxxxxxx",
        "secret": "xxxxxxxx",
        "options": {
            "defaultType": "spot" // or whatever
        }
    }
}

@carlosmiei

Copy link
Copy Markdown
Collaborator Author

additionally, I had a thought that in keys.json we might add one sample entry, like:

{
    "xyzexchange" : {
        "httpProxy": "012.345.678.910"
        "apiKey": "xxxxxxxx",
        "secret": "xxxxxxxx",
        "options": {
            "defaultType": "spot" // or whatever
        }
    }
}

@ttodua sure will add it

@ttodua

ttodua commented May 7, 2023

Copy link
Copy Markdown
Member

yeah, sampleExchange reads better

@carlosmiei carlosmiei changed the title Tests: move proxy to skip-tests.json Tests: move proxy to skip-tests.json [ci skip] May 7, 2023
@kroitor kroitor merged commit bb3ab45 into ccxt:master May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants