fix: clear full-main CodeQL findings - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
os.path.joinWhy this follows #16
PR #16 introduced CodeQL. Its pull-request analysis covered the changed lines and passed, while the first post-merge analysis of
mainsurfaced eight pre-existing quality findings in shipped Python hooks. This follow-up addresses all eight CodeQL findings rather than treating the green PR check as proof that the complete default branch was clean.Verification
python -m pytest -q— 50 passedcoverage run -m pytest -q && coverage report— 715 statements, 69 missed, 90%bash tests/statusline/test_heat_rgb.sh— 22 passedbash tests/statusline/test_fit_and_pace.sh— 53 passedpython -m py_compile ...— passed for all three changed Python entry pointsgit diff --check— passedCloses the CodeQL findings currently numbered 11–18 once the default-branch analysis sees this revision.