Remove the Snyk vulnerabilities widget#211
Merged
MattIPv4 merged 1 commit intoJun 5, 2026
Merged
Conversation
Contributor
Author
|
@MattIPv4 i think so, if there is no plan to restore the data source, removing it entirely is cleaner. i would happy to do the removal in this PR |
Member
|
👍 Go for it |
The Snyk widget service (snyk-widget.herokuapp.com) has been returning errors for all libraries for around a year (see cdnjs#170), with no plan to restore the data source. Remove it entirely: the get_vulns util, the shield in library_hero, and the snyk config, so its dead requests can no longer hang or clutter library pages.
7b32d15 to
7c23321
Compare
Contributor
Author
|
@MattIPv4 i have updated the PR, please let me know if all goods. thanks! |
MattIPv4
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the Snyk vulnerabilities widget. The Snyk widget service (
snyk-widget.herokuapp.com) has been returning errors for all libraries for around a year (#170), with no plan to restore the data source, so the shield never renders and its dead request can hang the library page when reached via the API-page search (#210). This removes the integration entirely rather than working around a service that no longer responds.Type of Change
pages/libraries/_library/index.vue, stopped passing the now-unusedversionprop toLibraryHero.components/library/library_hero.vue, removed the vulnerabilities shield, itsgetVulns/ShieldAltimports, theversionprop, and the data/watch/created that fetched vulnerabilities.util/get_vulns.js, deleted.data/config.js, removed thesnykApiandsnykKeyexports.What issue does this relate to?
Resolves #210. Resolves #170.
What should this PR do?
get_vulnsutility.snykApiandsnykKeyexports from config.versionprop wiring onLibraryHero.ShieldAltis still used inlibrary_asset_buttons.vue;node-fetchandbaseApiare still used by other utilities).What are the acceptance criteria?
snyk-widget.herokuapp.comfrom any library page.get_vulns,snykApi,snykKey, or thevulnsstate.npm test(ESLint + sass-lint) passes.Testing performed
npm test(ESLint + sass-lint) passes.nuxt build) compiles both the client and server bundles successfully, and proceeds through image/font optimization and sitemap generation with no errors.snyk,get_vulns,getVulns, orvulnsin source.npm run buildthennpm run start) and loaded/libraries/vue: the hero renders correctly (stars, GitHub, package, licenses, homepage, tags), no vulnerabilities shield, and no request is made tosnyk-widget.herokuapp.com.https://www.loom.com/share/c050ceac0a184693862dc7fef56d99e2