fix: refactor module generation ports to clarify ownership - #440
Merged
cdsap merged 1 commit intoSep 3, 2026
Merged
Conversation
cdsap
deleted the
issue/439-hermes-refactor-module-generation-ports-to-a1
branch
September 3, 2026 17:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
project-generator/src/main/kotlin/io/github/cdsap/projectgenerator/writer/ModulesWriter.kt defines the module-generation port interfaces at lines 87-122, while core generator implementations import them from the writer package, for example generator/planner/ModuleClassPlannerJvm.kt:3, generator/buildfiles/BuildFilesGeneratorJvm.kt:3, and generator/classes/ClassGeneratorJvm.kt:5.
Why this matters
This makes planning, class generation, test generation, resource generation, and build-file generation depend on the writer/orchestration package for their abstractions. That reverses the intended dependency direction and makes the writer package look like the owner of core generation contracts, which raises coupling and makes future generator tests or alternate orchestration harder to reason about.
Proposed change
Move ModuleClassPlanner, ClassGenerator, TestGenerator, BuildFilesGenerator, and ResourceGeneratorA unchanged into a small core-facing file such as project-generator/src/main/kotlin/io/github/cdsap/projectgenerator/generator/ModuleGenerationPorts.kt or generator/ports/ModuleGenerationPorts.kt, then update imports in ModulesWriter and the existing implementations. Keep names and method signatures unchanged.
Notes
DDD and clean architecture lens: the writer is an adapter/orchestrator that should depend on generation contracts, not own the contracts that planners and generators implement. This is a small package-boundary cleanup with no domain model or output-format change.
Fixes #439
Changes
project-generator/src/main/kotlin/io/github/cdsap/projectgenerator/generator/ModuleGenerationPorts.ktproject-generator/src/main/kotlin/io/github/cdsap/projectgenerator/generator/buildfiles/BuildFilesGeneratorAndroid.ktproject-generator/src/main/kotlin/io/github/cdsap/projectgenerator/generator/buildfiles/BuildFilesGeneratorJvm.ktproject-generator/src/main/kotlin/io/github/cdsap/projectgenerator/generator/classes/ClassGeneratorAndroid.ktproject-generator/src/main/kotlin/io/github/cdsap/projectgenerator/generator/classes/ClassGeneratorAndroidLegacy.ktproject-generator/src/main/kotlin/io/github/cdsap/projectgenerator/generator/classes/ClassGeneratorJvm.ktproject-generator/src/main/kotlin/io/github/cdsap/projectgenerator/generator/planner/ModuleClassPlannerAndroid.ktproject-generator/src/main/kotlin/io/github/cdsap/projectgenerator/generator/planner/ModuleClassPlannerAndroidLegacy.ktproject-generator/src/main/kotlin/io/github/cdsap/projectgenerator/generator/planner/ModuleClassPlannerJvm.ktproject-generator/src/main/kotlin/io/github/cdsap/projectgenerator/generator/resources/ResourceGenerator.ktproject-generator/src/main/kotlin/io/github/cdsap/projectgenerator/generator/test/TestGeneratorAndroid.ktproject-generator/src/main/kotlin/io/github/cdsap/projectgenerator/generator/test/TestGeneratorAndroidLegacy.ktproject-generator/src/main/kotlin/io/github/cdsap/projectgenerator/generator/test/TestGeneratorJvm.ktproject-generator/src/main/kotlin/io/github/cdsap/projectgenerator/writer/ModulesWriter.ktproject-generator/src/test/kotlin/io/github/cdsap/projectgenerator/generator/ModuleGenerationPortsTest.ktproject-generator/src/test/kotlin/io/github/cdsap/projectgenerator/writer/ModulesWriterTest.ktVerification
./gradlew :project-generator:unitTest./gradlew :cli:test./gradlew ktlintCheck