fix(editor): prevent Safari slash command crash - #20
Merged
Conversation
Route slash menu placement through controller coordinates instead of DOM Range measurement so Safari no longer crashes when the trigger is typed.
cdskill
marked this pull request as ready for review
June 25, 2026 21:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rangemeasurement./.Why
Safari could crash when the slash command menu tried to position itself through the DOM selection/range fallback. Moving placement through the mounted editor view's position coordinates avoids mutating the editable DOM during measurement and keeps ProseMirror internals behind a small Qalma API.
Fixes #18
Validation
nx test editornx test sandboxnx test docstsc -p libs/editor/tsconfig.lib.json --noEmittsc -p libs/editor/tsconfig.spec.json --noEmittsc -p apps/sandbox/tsconfig.json --noEmittsc -p apps/sandbox/tsconfig.spec.json --noEmittsc -p apps/docs/tsconfig.app.json --noEmittsc -p apps/docs/tsconfig.spec.json --noEmitnx lint editornx lint sandboxnx lint docsnx build sandbox/in the sandbox editor, menu opens, no crash, no console errors