[Bugfix] model.compare(dataset) does not work for the RPI test script #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the transmission_RPI.py example script, an error is raised when calling
model.compare(dataset); see failure log at the end. This bug seems to originate from the shape ofsim_datain the following linecdtools/src/cdtools/models/base.py
Line 875 in b3a70ec
Specifically, in the case of a FancyPtycho (and presumably other ptychography) model, the shape of
sim_datawill be (N, M). However, if an RPI model is used, the shape ofsim_databecomes (N,), which causes an invalid shape error to get thrown when plotting an image.The bugfix solves this issue by only adding the
[0]whenever the shape of thesim_datais bigger than 2 dimensions.Failure log