Skip to content

[Bugfix] model.compare(dataset) does not work for the RPI test script #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
allevitan merged 2 commits into from
Jun 12, 2025
Merged

[Bugfix] model.compare(dataset) does not work for the RPI test script #32

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c784de
Fixed sim_data shape change in CDIModel.compare for RPI measurements
yoshikisd Jun 12, 2025
3131881
Merge branch 'cdtools-developers:master' into bugfix/rpi_compare
yoshikisd Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/cdtools/models/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -872,7 +872,13 @@ def update(idx):
updating = True if len(axes[0].images) >= 1 else False

inputs, output = dataset[idx:idx+1]
sim_data = self.forward(*inputs).detach().cpu().numpy()[0]
sim_data = self.forward(*inputs).detach().cpu().numpy()
# The length of sim_data.shape changes when you're doing
# either a ptycho (3) or an RPI (2) reconstruction.
# We need to make sure that sim_data is 2D.
if len(sim_data.shape) > 2:
sim_data = sim_data[0]

meas_data = output.detach().cpu().numpy()[0]
if hasattr(self, 'mask') and self.mask is not None:
mask = self.mask.detach().cpu().numpy()
Expand Down