Fix a memory leak in the plotting - #87
Merged
Merged
Conversation
allevitan
commented
Jul 23, 2026
allevitan
left a comment
allevitan
left a comment
Collaborator
Author
There was a problem hiding this comment.
Gave it a look after sleeping on it, still looks solid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This memory leak had to do with callbacks which closed over stale tensors that would never be released, and only appeared in panel plot mode. The fix is to just check explicitly for new callbacks after each iteration and release them within the model.inspect() code.