Skip to content

fix: defer confirmation handling to resolve Windows event loop race condition#258

Merged
dwash96 merged 1 commit intocecli-dev:v0.90.0from
tgbender:fix/windows-confirmation-race
Dec 15, 2025
Merged

fix: defer confirmation handling to resolve Windows event loop race condition#258
dwash96 merged 1 commit intocecli-dev:v0.90.0from
tgbender:fix/windows-confirmation-race

Conversation

@tgbender
Copy link
Copy Markdown

When confirm_ask requests input, it reuses the underlying io.input_task. Since Coder.input_task is also awaiting io.input_task, both tasks wake up when the user types a response.

  1. confirm_ask receives the input. If it's invalid (e.g., "what?"), it rejects it and loops, asking again.
  2. Coder.input_task also receives the input. Because confirm_ask rejected it, the confirmation_acknowledgement flag is not set.
  3. Consequently, Coder.input_task treats the invalid confirmation response as a new chat message (user_message), triggering a new discussion workflow with the LLM.

@tgbender
Copy link
Copy Markdown
Author

So I've now ran into this command interception issue on macos as well. It'll prompt for the add file y/n/s and sometimes hitting that will send a "n" and trigger another exchange with the llm. I think this'll fix it (at least it appears to on my device) but worth getting another set of eyes on it.

@dwash96 dwash96 changed the base branch from main to v0.90.0 December 15, 2025 04:45
@dwash96
Copy link
Copy Markdown
Collaborator

dwash96 commented Dec 15, 2025

This probably also addresses #260, good looking out, merging into 0.90.0

@dwash96 dwash96 merged commit d2a59d7 into cecli-dev:v0.90.0 Dec 15, 2025
8 checks passed
@dwash96 dwash96 mentioned this pull request Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants