fix: Handle UnicodeDecodeError in .gitignore files#493
Closed
szmania wants to merge 4 commits intocecli-dev:mainfrom
Closed
fix: Handle UnicodeDecodeError in .gitignore files#493szmania wants to merge 4 commits intocecli-dev:mainfrom
szmania wants to merge 4 commits intocecli-dev:mainfrom
Conversation
Co-authored-by: cecli (openai/gemini_cli/gemini-2.5-pro)
Co-authored-by: cecli (openai/gemini_cli/gemini-2.5-pro)
Co-authored-by: cecli (openai/gemini_cli/gemini-2.5-pro)
Co-authored-by: cecli (openai/gemini_cli/gemini-2.5-pro)
Collaborator
|
Hey, I'm addressing the tree sitter CI/CD stuff in 0.99.6 so can you update this PR to remove the pyproject and import changes? |
dwash96
pushed a commit
that referenced
this pull request
Apr 28, 2026
Collaborator
|
Adding to 0.99.8! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a
UnicodeDecodeErrorthat occurs whenceclitries to read.gitignorefiles containing non-ASCII characters on Windows systems withcp1252as the default encoding.Problem
When running
cecliin repositories with.gitignorefiles containing Unicode characters (like emojis, non-English text, or special symbols), the file watcher would crash with:This happened because the code was using the system's default encoding (
cp1252on Windows) instead of explicitly using UTF-8, which is the standard encoding for.gitignorefiles.Solution
Modified
cecli/watch.pyto:encoding="utf-8"when reading.gitignorefileserrors="ignore"to skip problematic characters instead of crashingChanges
cecli/watch.pyload_gitignoresfunction)Testing
This fix has been tested with:
.gitignorefiles with Unicode characterscp1252default encoding.gitignorefilesThe file watcher now gracefully handles any encoding issues without crashing, making
ceclimore robust across different environments and repository configurations.Related Issues
Fixes encoding issues that could prevent
ceclifrom starting in repositories with international.gitignorefiles.