fix: Handle UnicodeDecodeError in .gitignore files and manage tree-sitter-languages dependency#498
Open
szmania wants to merge 5 commits intocecli-dev:mainfrom
Open
fix: Handle UnicodeDecodeError in .gitignore files and manage tree-sitter-languages dependency#498szmania wants to merge 5 commits intocecli-dev:mainfrom
szmania wants to merge 5 commits intocecli-dev:mainfrom
Conversation
Co-authored-by: cecli (openai/gemini_cli/gemini-2.5-pro)
Co-authored-by: cecli (openai/gemini_cli/gemini-2.5-pro)
Co-authored-by: cecli (openai/gemini_cli/gemini-2.5-pro)
Co-authored-by: cecli (openai/gemini_cli/gemini-2.5-pro)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses two key issues:
UnicodeDecodeError in .gitignore files: Implements proper encoding handling when reading .gitignore files to prevent decode errors with non-ASCII characters.
tree-sitter-languages dependency management:
tree_sitter_languages==1.10.2to requirements.in for Python <= 3.12Changes
.github/workflows/ubuntu-tests.ymlto use only supported Python versions (3.10, 3.11, 3.12)requirements/requirements.into include tree_sitter_languages dependency with proper Python version constraintsTesting
The changes have been tested locally and ensure compatibility with the current codebase while maintaining proper dependency management.
Fixes: #493 (UnicodeDecodeError in .gitignore files)