MEMAP: Fixing bug with auto TAR increment (Issue #15). #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TAR register can be auto incremented after every write or read from DRW. However this is only guaranteed to work for the lowest 10 bits of TAR. Above that it's implementation defined. On some targets it's just the 10 bits, meaning that something unknown <implementation defined> happens if you go over a !KB boundary. The previous code dealt with this, by rewriting the TAR register every 1KB. However that doesn't work if you don't start your writes 1KB aligned. For example, if you write 1KB starting at address 0x200, the first 512 bytes write OK, after that it's implementation defined. On my target it wrapped to 0 and wrote the last 512 bytes there. My fix re-writes the TAR register whenever you hit a 1KB boundary, regardless of start address.
Owner
|
Awsome work! Thanks Andy! Will look into it next week :-) |
Contributor
Author
|
Any problems with this? |
Owner
|
Thank you @andrewparlane ! No problems.. just summertime.. sorry :-) |
Contributor
Author
|
NP.
…On 15 August 2017 at 15:09, Tomasz CEDRO ***@***.***> wrote:
Thank you @andrewparlane <https://github.com/andrewparlane> ! :-)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#16 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AE51OkVdTF0iMfluaJ8V4tECkiTNJJABks5sYezfgaJpZM4OD9m0>
.
|
Owner
|
Btw @andrewparlane have you seen the https://github.com/mbedmicro/DAPLink project? It really speeds things up compared to LibSWD over USB from the Host.. DAPLink is a firmware put on MCU that dramatically speeds things up :-) |
Contributor
Author
|
Sure, I've been using it on my NXP frdm boards. Unfortunately it's not set
up in a way that will work for us on our custom boards.
…On 15 August 2017 at 15:41, Tomasz CEDRO ***@***.***> wrote:
Btw @andrewparlane <https://github.com/andrewparlane> have you seen the
https://github.com/mbedmicro/DAPLink project? It really speeds things up
compared to LibSWD over USB from the Host.. DAPLink is a firmware put on
MCU that dramatically speeds things up :-)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#16 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AE51OrNxgZZtnDq3oXp2V_kMAqc8wxjOks5sYfRMgaJpZM4OD9m0>
.
|
Owner
|
Not possible to customize? I see it running on a different boards, MCU and Targets.. looks very promising project! :-) But also nice to hear LibSWD has its unique advantages, thanks! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TAR register can be auto incremented after every write or read from
DRW. However this is only guaranteed to work for the lowest 10 bits of
TAR. Above that it's implementation defined.
On some targets it's just the 10 bits, meaning that something unknown
happens if you go over a !KB boundary.
The previous code dealt with this, by rewriting the TAR register every
1KB. However that doesn't work if you don't start your writes 1KB
aligned.
For example, if you write 1KB starting at address 0x200, the first 512
bytes write OK, after that it's implementation defined. On my target it
wrapped to 0 and wrote the last 512 bytes there.
My fix re-writes the TAR register whenever you hit a 1KB boundary,
regardless of start address.