Cef.Shutdown() too slow on version compiled from source

[rfgamaral]

I have been running CefSharp v33.0.2 (from NuGet) and so far so good. But because of recent issues (i.e. #608) I felt the need to compile CefSharp from source and use the latest master build in my project.

Maybe I missed something important, but here's the process I followed for this:

1. Cloned CefSharp and restored all packages with NuGet.
2. Opened CefSharp3.sln and built everything from Build » Batch Build....
3. Built the CefSharp.Common and CefSharp.WinForms NuGet packages with commands from build.ps1 file.
   • The files CefSharp.Common.37.0.0-pre01.nupkg and CefSharp.WinForms.37.0.0-pre01.nupkg were generated.
4. Configured the NuGet Package Sources (Visual Studio settings) to look for packages inside the cloned CefSharp\NuGet folder where the .nupkg files are located (placed this source at the top).
5. Updated my project to the pre-release packages available.

My project packages.config went from this:

<package id="cef.redist" version="3.1750.1738" targetFramework="net45" />
<package id="CefSharp.Common" version="33.0.2" targetFramework="net45" />
<package id="CefSharp.WinForms" version="33.0.2" targetFramework="net45" />

To this:

<package id="cef.redist.x64" version="3.2062.1898" targetFramework="net45" />
<package id="cef.redist.x86" version="3.2062.1898" targetFramework="net45" />
<package id="CefSharp.Common" version="37.0.0-pre01" targetFramework="net45" />
<package id="CefSharp.WinForms" version="37.0.0-pre01" targetFramework="net45" />

Assuming my process is correct, after building a new version of my application with the latest "pre-release" from CefSharp's master branch. The call to Cef.Shutdown() has become incredibly slow. I'm calling the Shutdown method when the user exits the application (by pressing Exit in a context menu) and it took more than 10 seconds to close the whole thing.

This did not happen on the previous version.

After looking closer to IntelliTrace I noticed a bunch of thrown and caught exceptions, 5 of each of the following:

Exception:Thrown: "The ServiceHost close operation timed out after 00:00:09.9857724.  This could be because a client failed to close a sessionful channel within the required time.  The time allotted to this operation may have been a portion of a longer timeout." (System.TimeoutException)
A System.TimeoutException was thrown: "The ServiceHost close operation timed out after 00:00:09.9857724.  This could be because a client failed to close a sessionful channel within the required time.  The time allotted to this operation may have been a portion of a longer timeout."
Time: 17/11/2014 23:06:27
Thread:<No Name>[8836]

Exception:Thrown: "The operation cannot be completed because the pipe was closed.  This may have been caused by the application on the other end of the pipe exiting." (System.ServiceModel.CommunicationObjectAbortedException)
A System.ServiceModel.CommunicationObjectAbortedException was thrown: "The operation cannot be completed because the pipe was closed.  This may have been caused by the application on the other end of the pipe exiting."
Time: 17/11/2014 23:06:27
Thread:Worker Thread[1548]

Is there anything else that I should probably be doing to make sure this v37 works as expected?

[amaitland]

It sounds like it's waiting for the WCF service host to close

https://github.com/cefsharp/CefSharp/blob/master/CefSharp.Core/ManagedCefBrowserAdapter.h#L37

Is your latest code available somewhere?

FYI you can reference master builds from our new myget repository https://www.myget.org/F/cefsharp/

Latest master build is tagged as 37.0.0-CI411 (script currently builds PR's as well, so couple of tweaks still required to the feed)

[amaitland]

FYI #585 also relates to a shutdown issue, might be worth checking out

[rfgamaral]

Is your latest code available somewhere?

Yes. Just clone the latest master branch from rfgamaral/SlackUI and change the CefSharp dependencies to the ones in the MyGet repository and you can see the problem. Cef.Shutdown() is at: https://github.com/rfgamaral/SlackUI/blob/master/SlackUI/Core/NotificationContext.cs#L135

FYI you can reference master builds from our new myget repository https://www.myget.org/F/cefsharp/

Latest master build is tagged as 37.0.0-CI411 (script currently builds PR's as well, so couple of tweaks still required to the feed)

Awesome! I don't need to have all that work compiling it myself, thanks. Just a question though... Does the NuGet package in there compile all opened PR's or just a few selected ones? Which ones?

[rfgamaral]

Do you guys have any idea what is really causing this and how it can be fixed?

This is preventing me from moving my application forward and fixing some issues because it's really annoying to wait around 10 seconds for the application to normally close. It makes debugging a nightmare and I can never release a new version like this.

No pressure though, keep doing your thing :)

[amaitland]

Does the NuGet package in there compile all opened PR's or just a few selected ones? Which ones?

Doesn't generate packages for PR's at all now.

Do you guys have any idea what is really causing this and how it can be fixed?

No idea at this stage unfortunately.

[jornh]

Sorry haven't got a debugger in front of me right now. So, a question: When are you calling https://github.com/rfgamaral/SlackUI/blob/v1.0.14306.1755/SlackUI/Forms/WrapperForm.cs#L121 compared to when you Shutdown() CEF?

[rfgamaral]

The Dispose is instant, but that is only called after Application.Exit which is only called after Cef.Shutdown. As mentioned in #585, I tried to dispose of every ChormiumWebBrowser instances before calling shutdown, but it didn't really help. Shutdown still took like 10 seconds...

[rfgamaral]

I tried something else... If I comment out Cef.Shutdown, the ChromiumWebBrowser Dispose method will now take like 10 seconds like the Cef.Shutdown used to take.

[amaitland]

Need to override BrowserProcessServiceHost.OnClosing and close the OperationContext.Channel if it's open.

[rfgamaral]

I'm confused @amaitland, are you saying that I should do that on my application (and is that the expected solution for everyone using CefSharp?) or that that should be done on CefSharp source?

[amaitland]

Changes need to be made to CefSharp source code. Just need to make sure the callback channel is closed before closing the ServiceHost, otherwise it waits for the timeout period (which I believe is 10seconds)

[amaitland]

e.g changes to https://github.com/cefsharp/CefSharp/blob/master/CefSharp/Internals/BrowserProcessServiceHost.cs are required

[amaitland]

Try 37.0.0-CI442 (it should be published by AppVeyor in the next 5mins).

It will contain 37c8c86