Javascript Binding - Only call Connect for main browser (not popups) #675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
There's also an issue when opening a popup the context is switched to the window, so scripts are executed in the popup window. When the window is closed the context is never returned to the main window. Just disabling Js execution in popups for now. (We don't keep track of popups, so there currently isn't a way to specify against which context the script should be executed). Hope this makes sense. |
amaitland
changed the title
amaitland
added a commit
that referenced
this pull request
Dec 11, 2014
Javascript Binding - Only call Connect for main browser (not popups)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt to fix #614