Skip to content

Conversation

@perlun
Copy link
Member

@perlun perlun commented Feb 10, 2015

Hi guys,

Just a (very) quick one, since we seem to need this at work. Doing some clever JS hacks that breaks if we do a document.location-based redirect, so that's why I'm experimenting in this direction - maybe injecting some JS early in the page load can work? You know the feeling. 😄

@amaitland or @jornh, I assume I have your blessing to merge this into the CefSharp1 branch? 😉 (We're still using CefSharp1, will hopefully upgrade later this year as it looks now.)

Also added an extra flag in the LoadCompletedEventArgs that indicates whether the load event relates to the main frame or not.
@amaitland
Copy link
Member

I assume I have your blessing to merge this into the CefSharp1 branch? 😉 (We're still using CefSharp1, will hopefully upgrade later this year as it looks now.)

Merge away 👍 Were you planning on releasing a Nuget package?

@amaitland amaitland added the cef1 label Feb 11, 2015
@perlun
Copy link
Member Author

perlun commented Feb 12, 2015

Thanks! Yes, I will, 1.25.8 it is. Coming up in a minute or two.

Btw, thanks a lot for doing a great job w/ taking care of the project!

perlun added a commit that referenced this pull request Feb 12, 2015
…t-handler

Added LoadStarted event handler
@perlun perlun merged commit 1a75c9f into CefSharp1 Feb 12, 2015
@perlun perlun deleted the feature/added-load-started-event-handler branch February 12, 2015 05:28
@perlun
Copy link
Member Author

perlun commented Feb 12, 2015

Also, if someone wants to forward-port this to CefSharp 39.x, feel free. If you don't, I will probably end up doing it once we do the move to CEF3-based CefSharp, whenever that happens. (haven't been "forced" to do it yet, since CefSharp1 works quite well, even though the Chromium version is getting rather antique of course...)

@amaitland
Copy link
Member

Btw, thanks a lot for doing a great job w/ taking care of the project!

No problem 😄

Also, if someone wants to forward-port this to CefSharp 39.x, feel free

Names were changed to mirror the Cef naming, both start and end are implemented.
https://github.com/cefsharp/CefSharp/blob/master/CefSharp/IWebBrowser.cs#L29

@perlun
Copy link
Member Author

perlun commented Feb 12, 2015

Cool! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants