Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions CefSharp.WinForms/WebView.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -332,16 +332,19 @@ namespace WinForms
ConsoleMessage(this, gcnew ConsoleMessageEventArgs(message, source, line));
}

void WebView::OnFrameLoadStart(String^ url)
void WebView::OnFrameLoadStart(String^ url, bool isMainFrame)
{
_browserCore->OnFrameLoadStart();

LoadStartedEventArgs^ args = gcnew LoadStartedEventArgs(url, isMainFrame);
LoadStarted(this, args);
}

void WebView::OnFrameLoadEnd(String^ url)
void WebView::OnFrameLoadEnd(String^ url, bool isMainFrame)
{
_browserCore->OnFrameLoadEnd();

LoadCompletedEventArgs^ args = gcnew LoadCompletedEventArgs(url);
LoadCompletedEventArgs^ args = gcnew LoadCompletedEventArgs(url, isMainFrame);
LoadCompleted(this, args);
}

Expand Down
5 changes: 3 additions & 2 deletions CefSharp.WinForms/WebView.h
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ namespace WinForms
virtual event ConsoleMessageEventHandler^ ConsoleMessage;
virtual event KeyEventHandler^ BrowserKey;
virtual event LoadCompletedEventHandler^ LoadCompleted;
virtual event LoadStartedEventHandler^ LoadStarted;

WebView()
{
Expand Down Expand Up @@ -181,8 +182,8 @@ namespace WinForms

virtual void SetNavState(bool isLoading, bool canGoBack, bool canGoForward);

virtual void OnFrameLoadStart(String^ url);
virtual void OnFrameLoadEnd(String^ url);
virtual void OnFrameLoadStart(String^ url, bool isMainFrame);
virtual void OnFrameLoadEnd(String^ url, bool isMainFrame);
virtual void OnTakeFocus(bool next);
virtual void OnConsoleMessage(String^ message, String^ source, int line);

Expand Down
9 changes: 6 additions & 3 deletions CefSharp.Wpf/WebView.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -623,16 +623,19 @@ namespace CefSharp
return _browserCore->GetBoundObjects();
}

void WebView::OnFrameLoadStart(String^ url)
void WebView::OnFrameLoadStart(String^ url, bool isMainFrame)
{
_browserCore->OnFrameLoadStart();

LoadStartedEventArgs^ args = gcnew LoadStartedEventArgs(url, isMainFrame);
LoadStarted(this, args);
}

void WebView::OnFrameLoadEnd(String^ url)
void WebView::OnFrameLoadEnd(String^ url, bool isMainFrame)
{
_browserCore->OnFrameLoadEnd();

LoadCompletedEventArgs^ args = gcnew LoadCompletedEventArgs(url);
LoadCompletedEventArgs^ args = gcnew LoadCompletedEventArgs(url, isMainFrame);
LoadCompleted(this, args);
}

Expand Down
5 changes: 3 additions & 2 deletions CefSharp.Wpf/WebView.h
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ namespace CefSharp
virtual event ConsoleMessageEventHandler^ ConsoleMessage;
virtual event KeyEventHandler^ BrowserKey;
virtual event LoadCompletedEventHandler^ LoadCompleted;
virtual event LoadStartedEventHandler^ LoadStarted;

WebView()
{
Expand Down Expand Up @@ -291,8 +292,8 @@ namespace CefSharp

virtual void SetNavState(bool isLoading, bool canGoBack, bool canGoForward);

virtual void OnFrameLoadStart(String^ url);
virtual void OnFrameLoadEnd(String^ url);
virtual void OnFrameLoadStart(String^ url, bool isMainFrame);
virtual void OnFrameLoadEnd(String^ url, bool isMainFrame);
virtual void OnTakeFocus(bool next);
virtual void OnConsoleMessage(String^ message, String^ source, int line);

Expand Down
1 change: 1 addition & 0 deletions CefSharp/CefSharp.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@
<ClInclude Include="ISchemeHandler.h" />
<ClInclude Include="IWebBrowser.h" />
<ClInclude Include="LoadCompletedEventArgs.h" />
<ClInclude Include="LoadStartedEventArgs.h" />
<ClInclude Include="MCefRefPtr.h" />
<ClInclude Include="Internals\JavascriptBinding\PropertyAccessor.h" />
<ClInclude Include="RenderClientAdapter.h" />
Expand Down
3 changes: 3 additions & 0 deletions CefSharp/CefSharp.vcxproj.filters
Original file line number Diff line number Diff line change
Expand Up @@ -190,5 +190,8 @@
<ClInclude Include="ISchemeHandler.h">
<Filter>Header Files</Filter>
</ClInclude>
<ClInclude Include="LoadStartedEventArgs.h">
<Filter>Header Files</Filter>
</ClInclude>
</ItemGroup>
</Project>
4 changes: 2 additions & 2 deletions CefSharp/ClientAdapter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ namespace CefSharp
_browserControl->SetNavState(true, false, false);
}

_browserControl->OnFrameLoadStart(toClr(frame->GetURL()));
_browserControl->OnFrameLoadStart(toClr(frame->GetURL()), frame->IsMain());
}

void ClientAdapter::OnLoadEnd(CefRefPtr<CefBrowser> browser, CefRefPtr<CefFrame> frame, int httpStatusCode)
Expand All @@ -139,7 +139,7 @@ namespace CefSharp
_browserControl->SetNavState(false, browser->CanGoBack(), browser->CanGoForward());
}

_browserControl->OnFrameLoadEnd(toClr(frame->GetURL()));
_browserControl->OnFrameLoadEnd(toClr(frame->GetURL()), frame->IsMain());
}

bool ClientAdapter::OnLoadError(CefRefPtr<CefBrowser> browser, CefRefPtr<CefFrame> frame, ErrorCode errorCode, const CefString& failedUrl, CefString& errorText)
Expand Down
5 changes: 3 additions & 2 deletions CefSharp/IWebBrowser.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
#include "BrowserCore.h"
#include "ConsoleMessageEventArgs.h"
#include "LoadCompletedEventArgs.h"
#include "LoadStartedEventArgs.h"

using namespace System;
using namespace System::ComponentModel;
Expand Down Expand Up @@ -65,8 +66,8 @@ namespace CefSharp

void SetNavState(bool isLoading, bool canGoBack, bool canGoForward);

void OnFrameLoadStart(String^ url);
void OnFrameLoadEnd(String^ url);
void OnFrameLoadStart(String^ url, bool isMainFrame);
void OnFrameLoadEnd(String^ url, bool isMainFrame);
void OnTakeFocus(bool next);
void OnConsoleMessage(String^ message, String^ source, int line);

Expand Down
6 changes: 4 additions & 2 deletions CefSharp/LoadCompletedEventArgs.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,14 @@ namespace CefSharp
public ref class LoadCompletedEventArgs : EventArgs
{
String^ _url;
bool _isMainFrame;

public:
LoadCompletedEventArgs(String^ url)
: _url(url) {}
LoadCompletedEventArgs(String^ url, bool isMainFrame)
: _url(url), _isMainFrame(isMainFrame) {}

property String^ Url { String^ get() { return _url; } }
property bool IsMainFrame { bool get() { return _isMainFrame; } }
};

public delegate void LoadCompletedEventHandler(Object^ sender, LoadCompletedEventArgs^ url);
Expand Down
22 changes: 22 additions & 0 deletions CefSharp/LoadStartedEventArgs.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
#include "Stdafx.h"
#pragma once

using namespace System;

namespace CefSharp
{
public ref class LoadStartedEventArgs : EventArgs
{
String^ _url;
bool _isMainFrame;

public:
LoadStartedEventArgs(String^ url, bool isMainFrame)
: _url(url), _isMainFrame(isMainFrame) {}

property String^ Url { String^ get() { return _url; } }
property bool IsMainFrame { bool get() { return _isMainFrame; } }
};

public delegate void LoadStartedEventHandler(Object^ sender, LoadStartedEventArgs^ url);
}