Skip to content

Migrate from std::container to absl::node_hash_map/node_hash_set#14

Merged
TristonianJones merged 1 commit into
cel-expr:masterfrom
TristonianJones:absl-update
Mar 29, 2019
Merged

Migrate from std::container to absl::node_hash_map/node_hash_set#14
TristonianJones merged 1 commit into
cel-expr:masterfrom
TristonianJones:absl-update

Conversation

@TristonianJones

Copy link
Copy Markdown
Collaborator

Update to use the relevant absl::node_hash_map and absl::node_hash_set where appropriate.

@kyessenov kyessenov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@TristonianJones
TristonianJones merged commit 1b8c09b into cel-expr:master Mar 29, 2019
@TristonianJones
TristonianJones deleted the absl-update branch March 29, 2019 19:28
@Alfus

Alfus commented Apr 16, 2019

Copy link
Copy Markdown
Contributor

FYI, these should all probably be absl::flat_hash_map ;-) (I really doubt I relied on pointer stability anywhere)

@TristonianJones

Copy link
Copy Markdown
Collaborator Author

@Alfus this was part of a large scale change (not done by the core team) to replace deprecated types. I can make this a bug if you'd like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants