You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Now, I'd be in the camp of adding the output .rs files from the .protos to the repo. My understanding is that we don't expect these to change by themselves and that as such the output should also not change. This would save time and resources in the CI. wdyt?
you can also use protox which is native rust and doesn't depend on protoc fwiw.
Right, I'm mostly concerned about resources wasted here. Arguably it won't be too much an issue for some time, but on project with more collaborators and as such PRs (on a whole lot more repos too tbh), but which has a "paid for account", we get throttled quite a bit. So if there is no need to run any .proto compilation (whatever the mean), I'd opt for the lazy approach. If only, that'd probably shorten the feedback loop on CI running to an end as well, which is always desirable I think.
you can also use protox which is native rust and doesn't depend on protoc fwiw.
Just to be clear tho, I think the build.rs should be there, with matching cargo:rerun-if-changed, for automatic generation when needed. I just wouldn't do it on every builds, as that's not needed and speeds builds (also doesn't require further installs for "newcomers" - tho, if @howardjohn 's proposal mitigates that and protox being up to our needs, I'm totally fine using that)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows up on #250 by just adding the conformance test suite harness.