Skip to content

celery#5736, Fix disable_sync_subtasks not respected in ResultSet#5737

Merged
auvipy merged 2 commits intocelery:masterfrom
gsfish:fix-5736
Sep 18, 2019
Merged

celery#5736, Fix disable_sync_subtasks not respected in ResultSet#5737
auvipy merged 2 commits intocelery:masterfrom
gsfish:fix-5736

Conversation

@gsfish
Copy link
Contributor

@gsfish gsfish commented Sep 17, 2019

Note: Before submitting this pull request, please review our contributing
guidelines
.

Description

Fixes #5736

Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a test?

@codecov
Copy link

codecov bot commented Sep 18, 2019

Codecov Report

Merging #5737 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5737   +/-   ##
=======================================
  Coverage   83.36%   83.36%           
=======================================
  Files         144      144           
  Lines       16694    16694           
  Branches     2076     2076           
=======================================
  Hits        13917    13917           
  Misses       2561     2561           
  Partials      216      216
Impacted Files Coverage Δ
celery/result.py 62.19% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08bec60...98c3bc0. Read the comment docs.

@gsfish
Copy link
Contributor Author

gsfish commented Sep 18, 2019

can you add a test?

test added in t/unit/tasks/test_tasks.py

@auvipy auvipy added this to the 4.4.0 milestone Sep 18, 2019
@auvipy auvipy merged commit 3670b30 into celery:master Sep 18, 2019
mattklein pushed a commit to Jellyfish-AI/celery that referenced this pull request Oct 7, 2019
…lery#5737)

* celery#5736, Fix disable_sync_subtasks not respected in ResultSet

* Add test_get_sync_subtask_option for ResultSet
jeyrce pushed a commit to jeyrce/celery that referenced this pull request Aug 25, 2021
…lery#5737)

* celery#5736, Fix disable_sync_subtasks not respected in ResultSet

* Add test_get_sync_subtask_option for ResultSet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

disable_sync_subtasks setting not being respected while using ResultSet

2 participants