Conversation
WalkthroughThis update streamlines the connectivity of nodes within the network by standardizing the RPC endpoint configurations. It involves the removal of outdated URLs and the introduction of more generic endpoints, enhancing the network's communication framework. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (1)
- nodes/mocha-testnet.md (1 hunks)
Additional comments: 1
nodes/mocha-testnet.md (1)
- 68-68: The addition of
rpc.celestia-mocha.com/andrpc-mocha.pops.oneas new RPC endpoints for DA bridge, full, and light nodes aligns with the PR's objective of making endpoint URLs more generic. This should enhance the connectivity setup for nodes by providing more adaptable and less specific URLs.
|
|
||
| - `full.consensus.mocha-4.celestia-mocha.com` | ||
| - `consensus-full-mocha-4.celestia-mocha.com` | ||
| - `rpc.celestia-mocha.com/` |
There was a problem hiding this comment.
While the new endpoints are added, it's important to ensure that users are aware of the removal of specific URLs such as full.consensus.mocha-4.celestia-mocha.com and consensus-full-mocha-4.celestia-mocha.com. Clear communication in the documentation about these changes will help users transition smoothly to the new endpoints.
Consider adding a note or section that explicitly mentions the removal of specific URLs and guides users on how to adapt to the new, more generic endpoints.
|
after seeing slack chat we may need to revert this |
|
both original endpoints work for me, so i am reverting this PR. here are logs |
| @@ -65,8 +65,7 @@ run a local [full consensus node](./consensus-node.md) in order to download | |||
| full blocks from it. | |||
There was a problem hiding this comment.
also, the above note exists and should send people to the section specifically for full and bridge nodes
because the original endpoints worked. new one does not
because the original endpoints worked. new one does not
Overview
Checklist
Summary by CodeRabbit