Skip to content

update endpoint#1438

Merged
jcstein merged 2 commits intomainfrom
sysrex/update_mocha-4_rpc
Feb 26, 2024
Merged

update endpoint#1438
jcstein merged 2 commits intomainfrom
sysrex/update_mocha-4_rpc

Conversation

@sysrex
Copy link
Copy Markdown
Contributor

@sysrex sysrex commented Feb 26, 2024

Overview

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

Summary by CodeRabbit

  • Chores
    • Updated RPC endpoint configurations for improved connectivity and network communication by replacing specific URLs with more generic ones.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 26, 2024

Walkthrough

This update streamlines the connectivity of nodes within the network by standardizing the RPC endpoint configurations. It involves the removal of outdated URLs and the introduction of more generic endpoints, enhancing the network's communication framework.

Changes

File Change Summary
nodes/mocha-testnet.md Updated RPC endpoint configurations: Replaced specific URLs with generic ones.

🐇✨
In the land of code and net,
A change was made, better yet.
From old to new, the paths we set,
A hop, a skip, no need to fret.
For every node, a seamless bet.
🌟🐰

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 26, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://celestiaorg.github.io/docs-preview/./pr-1438/
on branch main at 2024-02-26 14:13 UTC

Copy link
Copy Markdown
Member

@jcstein jcstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @sysrex

Comment thread nodes/mocha-testnet.md Outdated
@jcstein jcstein merged commit 0ff444d into main Feb 26, 2024
@jcstein jcstein deleted the sysrex/update_mocha-4_rpc branch February 26, 2024 14:12
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 00e7fdc and f9bf62f.
Files selected for processing (1)
  • nodes/mocha-testnet.md (1 hunks)
Additional comments: 1
nodes/mocha-testnet.md (1)
  • 68-68: The addition of rpc.celestia-mocha.com/ and rpc-mocha.pops.one as new RPC endpoints for DA bridge, full, and light nodes aligns with the PR's objective of making endpoint URLs more generic. This should enhance the connectivity setup for nodes by providing more adaptable and less specific URLs.

Comment thread nodes/mocha-testnet.md Outdated

- `full.consensus.mocha-4.celestia-mocha.com`
- `consensus-full-mocha-4.celestia-mocha.com`
- `rpc.celestia-mocha.com/`
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the new endpoints are added, it's important to ensure that users are aware of the removal of specific URLs such as full.consensus.mocha-4.celestia-mocha.com and consensus-full-mocha-4.celestia-mocha.com. Clear communication in the documentation about these changes will help users transition smoothly to the new endpoints.

Consider adding a note or section that explicitly mentions the removal of specific URLs and guides users on how to adapt to the new, more generic endpoints.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between f9bf62f and 9bb938d.
Files selected for processing (1)
  • nodes/mocha-testnet.md (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • nodes/mocha-testnet.md

@jcstein
Copy link
Copy Markdown
Member

jcstein commented Feb 26, 2024

after seeing slack chat we may need to revert this

@jcstein
Copy link
Copy Markdown
Member

jcstein commented Feb 26, 2024

both original endpoints work for me, so i am reverting this PR. here are logs
https://app.warp.dev/block/zk6o58SYqBSryZL1ytvROD
https://app.warp.dev/block/H3N1vFmEeuIQlEmNlazdJS

Comment thread nodes/mocha-testnet.md
@@ -65,8 +65,7 @@ run a local [full consensus node](./consensus-node.md) in order to download
full blocks from it.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, the above note exists and should send people to the section specifically for full and bridge nodes

jcstein added a commit that referenced this pull request Feb 26, 2024
because the original endpoints worked. new one does not
jcstein added a commit that referenced this pull request Feb 26, 2024
because the original endpoints worked. new one does not
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants