Skip to content

fix: revert #1438 Update mocha-testnet.md#1441

Merged
jcstein merged 1 commit intomainfrom
jcstein-patch-4
Feb 26, 2024
Merged

fix: revert #1438 Update mocha-testnet.md#1441
jcstein merged 1 commit intomainfrom
jcstein-patch-4

Conversation

@jcstein
Copy link
Copy Markdown
Member

@jcstein jcstein commented Feb 26, 2024

because the original endpoints worked. new one does not

Overview

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

Summary by CodeRabbit

  • Bug Fixes
    • Updated RPC endpoint configurations for improved network connectivity and stability.

because the original endpoints worked. new one does not
@jcstein jcstein requested a review from sysrex February 26, 2024 15:07
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 26, 2024

Walkthrough

This update focuses on the Celestia Mocha testnet's RPC endpoint configurations. It involves replacing two outdated RPC endpoints with new ones, while keeping an additional existing endpoint unchanged. This change is aimed at ensuring users connect to the correct and updated nodes for their operations on the Mocha testnet.

Changes

File Path Change Summary
nodes/mocha-testnet.md Updated RPC endpoint configurations: replaced rpc.celestia-mocha.com with full.consensus.mocha-4.celestia-mocha.com and consensus-full-mocha-4.celestia-mocha.com; retained rpc-mocha.pops.one.

Related issues

  • bug: mocha rpcs not working #1337: This issue reports that the RPC endpoints mentioned in the documentation were not working. The changes in this PR directly address this issue by updating the RPC endpoints to the correct ones.

🐇✨
In the land of code and net,
A rabbit hopped, no time to fret.
With a flip and a script, it changed the game,
RPC paths now bear a new name.
Rejoice and connect, for now, you see,
Paths updated, as swift as can be.
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@jcstein jcstein merged commit b61232d into main Feb 26, 2024
@jcstein jcstein deleted the jcstein-patch-4 branch February 26, 2024 15:07
@github-actions
Copy link
Copy Markdown
Contributor

PR Preview Action v1.4.7
🚀 Deployed preview to https://celestiaorg.github.io/docs-preview/./pr-1441/
on branch main at 2024-02-26 15:08 UTC

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 0ff444d and 28fcd54.
Files selected for processing (1)
  • nodes/mocha-testnet.md (1 hunks)
Additional comments: 1
nodes/mocha-testnet.md (1)
  • 68-69: The addition of full.consensus.mocha-4.celestia-mocha.com and consensus-full-mocha-4.celestia-mocha.com endpoints, while retaining rpc-mocha.pops.one, aligns with the PR's objective to revert to the original, operational endpoint configurations. However, it's crucial to verify that these endpoints are correctly formatted and accessible. Additionally, ensure that any references to these endpoints elsewhere in the documentation or in code that relies on this document are updated accordingly to prevent any connectivity issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant