This repository was archived by the owner on Dec 23, 2023. It is now read-only.
Tags: Add TagContextBuilder.putLocal().#1851
Merged
songy23 merged 1 commit intocensus-instrumentation:masterfrom Apr 19, 2019
Merged
Tags: Add TagContextBuilder.putLocal().#1851songy23 merged 1 commit intocensus-instrumentation:masterfrom
songy23 merged 1 commit intocensus-instrumentation:masterfrom
Conversation
rghetia
approved these changes
Apr 19, 2019
Contributor
rghetia
left a comment
rghetia
left a comment
There was a problem hiding this comment.
LGTM.
wouldn't it make sense to add putPropagating also?
dinooliva
approved these changes
Apr 19, 2019
Contributor
Author
Make sense to me, will add in a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1849.
Add a convenient API so that users don't need to put a tag metadata over and over again when putting tags.