This repository was archived by the owner on Dec 23, 2023. It is now read-only.
Tags: Add TagContextBuilder.putPropagating().#1852
Merged
songy23 merged 2 commits intocensus-instrumentation:masterfrom Apr 19, 2019
Merged
Tags: Add TagContextBuilder.putPropagating().#1852songy23 merged 2 commits intocensus-instrumentation:masterfrom
songy23 merged 2 commits intocensus-instrumentation:masterfrom
Conversation
dinooliva
approved these changes
Apr 19, 2019
Contributor
dinooliva
left a comment
dinooliva
left a comment
There was a problem hiding this comment.
A few minor nits but good overall.
| - Allow setting custom namespace in Prometheus exporter. | ||
| - Add Cumulative (`DoubleCumulative`, `LongCumulative`, `DerivedDoubleCumulative`, `DerivedLongCumulative`) APIs. | ||
| - Add a convenient API `TagContextBuilder.putLocal()` that adds non-propagating tags. | ||
| - Add convenient APIs `TagContextBuilder.putLocal()` that adds non-propagating tags, |
Contributor
There was a problem hiding this comment.
consider: convenient -> convenience
| * <p>This is equivalent to calling {@code put(key, value, | ||
| * TagMetadata.create(TagTtl.METADATA_UNLIMITED_PROPAGATION))}. | ||
| * | ||
| * <p>Only call this method if you want propagating tags. If you just want tags for breaking down |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #1851.
Another convenient API that allows adding propagating tags without the need to always put a tag metadata.