This repository was archived by the owner on Dec 23, 2023. It is now read-only.
Exporter/Datadog, Elasticsearch: Add deadline option.#1886
Merged
songy23 merged 1 commit intocensus-instrumentation:masterfrom May 9, 2019
Merged
Exporter/Datadog, Elasticsearch: Add deadline option.#1886songy23 merged 1 commit intocensus-instrumentation:masterfrom
songy23 merged 1 commit intocensus-instrumentation:masterfrom
Conversation
dinooliva
approved these changes
May 8, 2019
Contributor
Agreed that there is a lot of duplication of logic/code related to deadlines, it would be better if there was a common way of handling them. |
Contributor
Author
|
Sounds good, I'll send a follow-up PR. |
This was referenced May 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another two of #1880.
I'm consider adding a common
SpanExportWithDeadlineinterface to reduce the duplicated codes, similar to https://github.com/census-instrumentation/opencensus-java/tree/master/exporters/metrics/util. WDYT?