Exporter/Trace: Refactor to use TimeLimitedHandler.#1890
Exporter/Trace: Refactor to use TimeLimitedHandler.#1890songy23 merged 1 commit intocensus-instrumentation:masterfrom
Conversation
|
hey @songy23 i'm curious about the deadlines you are adding to all the trace exporters. Is this to avoid blocking the Can the Stackdriver exporter still block the |
Correct, see #1767 (comment).
Stackdriver exporter still blocks the SpanExporterImplThread before deadline is exceeded. After that the exporter just drops any undelivered spans. This is the first step described in #1767 (comment). The second step is to make exporters async (non-blocking). |
|
@songy23 makes sense thanks! Glad i'm following along. |
Updates #1880.
The goal of this change is to reduce the code duplication added in recent exporter PRs (e.g #1884 #1885 #1886), as a follow up of #1887.