Skip to content

Show Codex sessions as Waiting when user action is required - #100

Merged
milanshen merged 8 commits into
mainfrom
cvu/codex-wait
Aug 21, 2026
Merged

Show Codex sessions as Waiting when user action is required#100
milanshen merged 8 commits into
mainfrom
cvu/codex-wait

Conversation

@calvintvu

@calvintvu calvintvu commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Context

Codex sessions can remain Active while they wait for a user response or command approval. This change marks those sessions as Waiting until the user responds or the approval completes.

Changes

  • Mark an open Codex turn as Waiting for an unanswered request_user_input call.
  • Mark an open Codex turn as Waiting for a pending sandbox approval.
  • Clear Waiting after an answer, completed approval, or newer user message.
  • Keep sessions Active for saved approval rules and ordinary commands.

Test

  • go test parse.go source.go fork.go types.go metadata.go discovery.go waiting_test.go — passed
  • go build ./... — passed
  • git diff --check origin/main...HEAD — passed
  • Manual: An unanswered request_user_input prompt showed Waiting.

Screenshots

  • Session board — Codex session shows Waiting during an unanswered question.
Screenshot 2026-08-18 at 10 49 59
  • Session board — Codex session shows Waiting during a pending approval.
Screenshot 2026-08-18 at 11 21 49

@calvintvu calvintvu added the bug Something isn't working label Aug 18, 2026
@calvintvu
calvintvu marked this pull request as ready for review August 18, 2026 18:23

@milanshen milanshen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three status-correctness findings.

Comment thread collector/internal/vendors/codex/parse.go Outdated
Comment thread collector/internal/vendors/codex/parse.go Outdated
Comment thread collector/internal/vendors/codex/parse.go Outdated
@calvintvu
calvintvu force-pushed the cvu/codex-wait branch 5 times, most recently from b6af5c4 to a01bc24 Compare August 18, 2026 23:32
@calvintvu
calvintvu force-pushed the cvu/codex-wait branch 2 times, most recently from a348e01 to 7557e12 Compare August 19, 2026 01:20
@milanshen
milanshen merged commit 2637abb into main Aug 21, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants