Smoke-test release packages from one matrix job - #29
Merged
Conversation
The arm64 and amd64 smoke blocks were 28 lines of identical inline bash,
differing only in the archive stem. Both also reimplemented, less
thoroughly, what scripts/smoke.sh already does for `make smoke`.
Replace both with one matrix job over {arm64, macos-15} and
{amd64, macos-15-intel} that unpacks the archive, checks --version
against the tag, and calls scripts/smoke.sh. Two copies of the release
gate become one, and the release path now exercises the same script a
developer runs locally.
Coverage goes up rather than down. The old blocks checked only that /
served a root div and /api/sessions parsed as JSON. smoke.sh also
asserts the page title, that a referenced /assets/*.js resolves, that
/coslash survives a direct hit, that a missing asset 404s instead of
falling back to the SPA document, and that an unrouted /api path 404s.
The smoke job needs a checkout to reach the script, and the arm64 run
moves out of `build`, so artifacts now upload before either arch is
verified. publish needs [build, smoke], so nothing publishes untested.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
luhe19001
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
release.ymlcarried the same 28-line smoke block twice — once inline inbuildfor arm64, once insmoke-intelfor amd64 — differing only in the archive stem. Two copies on the path that publishes binaries is where drift costs the most.Both also reimplemented, less thoroughly, what
collector/scripts/smoke.shalready does formake smoke.Changes
smokematrix job over{arm64, macos-15}and{amd64, macos-15-intel}. It unpacks the archive, checks--versionagainst the tag, and callsscripts/smoke.sh.publishnow needs[build, smoke].Coverage goes up, not down. The old blocks checked only that
/served aroot div and that/api/sessionsparsed as JSON.smoke.shadditionally asserts the page title, that a/assets/*.jsreferenced by the document resolves, that/coslashsurvives a direct hit, that a missing asset returns 404 rather than falling back to the SPA document, and that an unrouted/apipath returns 404. It also drops the third JSON validator — the old blocks usedpython3 -m json.tool,smoke.shusesjqwith agrepfallback.Two things reviewers should weigh:
actions/checkoutto reach the script. That is one extra step per arch, and it means the smoke job now tests the script at the tag being released rather than a copy frozen into the workflow.build, so artifacts upload before either arch is verified.publishneeds both jobs, so nothing untested reaches a release; the artifacts are internal, with 1-day retention.fail-fast: falseso one arch failing still reports the other.Test
ruby -ryamlparse — valid; jobs resolve tobuild → smoke → publish →bump-homebrew, matrix expands to the two expected pairs, nosmoke-intelreferences left.make -C collector dist VERSION=v9.9.9-test— passed, two archives pluschecksums.txt.- versionreturnedv9.9.9-test, andscripts/smoke.shpassed all seven assertions.scripts/smoke.sh <bare-binary> embeddedfails withno frontend assets are embedded in this binary. That is the one failure mode that could otherwise ship behind a green check.Not covered: the amd64 leg on real Intel hardware, and the tap-publish job — both unchanged by this PR and both unavailable locally.