Drop the synthesis.Home wrapper - #37
Merged
Merged
Conversation
synthesis.Home only returned settings.Home. Nothing outside the package called it, and inside the package it had three callers, so it added an exported name and one more place to look without adding behavior. Call settings.Home directly at those three sites. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
luhe19001
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
synthesis.Homeonly returnedsettings.Home. Nothing outside the package called it, and inside the package it had three callers, so it added an exported name and one more hop without adding behavior.Changes
synthesis.Home; callsettings.Homedirectly inSummariesDir,SynthesisCwd, andEnsureDirs.SummariesDirandSynthesisCwdstay. UnlikeHomethey add a path segment,and they have callers in
cache.go,runner.go, andcollector.go.Test
make -C collector check— passedmake -C collector test— passedmake -C collector release && make smoke— passedBooted the binary under an empty
HOMEand confirmed the directory layout isunchanged:
This is the behavior that would break if the wrapper had been resolving to a
different root than
settings.Home.