ceph_monstore_tool: fix the illegal memory access when update_paxos

[hjwsm1989]

http://tracker.ceph.com/issues/19070

[hjwsm1989]

@tchaikov please take a look

[tchaikov]

@hjwsm1989 before merging this PR, could you update the commit message with a "Conflicts:" section explaining why this change is not cherry-picked from master? thanks!

[smithfarm]

It would also be nice to have a tracker issue explaining what the bug is that this is fixing.

[hjwsm1989]

@tchaikov this is from the hammer branch, in this PR: #11125
i want to add commit message like this:
Conflicts:
Introduced in this hammer backport #11125, we use const char** instead of vector,which result the illegal memory access.

is that ok?

[tchaikov]

@hjwsm1989 i understand that you are fixing an issue introduced by #11125, but in general we tend to backport fixes from master. and this fix is only for hammer. that's why we want to explain the reason why we are not doing a cherry-pick here. so i'd recommend something like:

    Conflicts:
        we don't use C++11 in hammer. and this fix addresses the issue introduced by https://github.com/ceph/ceph/pull/11125, where we are iterating in a plain array instead of a std::vector in master. so this change is not cherry-picked from master.

i concur with @smithfarm , could you add a ticket in tracker to explain this problem addressed by the fix? thanks.

[hjwsm1989]

@tchaikov ok, i will update the commit message.

[hjwsm1989]

@smithfarm i opened an issue http://tracker.ceph.com/issues/19070

[tchaikov]

@hjwsm1989 could you put "Fixes: http://tracker.ceph.com/issues/19070" in your commit message right before your "Signed-off-by" tag?

[hjwsm1989]

@tchaikov done

[tchaikov]

thanks!

[smithfarm]

@hjwsm1989 Thanks for the fix. We'll do some test runs on it and report back here.

[smithfarm]

Hammer is EOL.