osd: add sanity check/warning on a few key configs#1964
Merged
Conversation
Warn when certain config values are set to bad values. Backport: firefly, dumpling Signed-off-by: Sage Weil <sage@inktank.com>
There was a problem hiding this comment.
I guess nobody will try to set osd_map_cache_size to osd_map_max_advance + 1 and be confused about the message.
Member
Author
There was a problem hiding this comment.
On Sun, 15 Jun 2014, Loic Dachary wrote:
I guess nobody will try to set osd_map_cache_size to osd_map_max_advance + 1
and be confused about the message.
Probably someone will, but it is better than worrying about an
off-by-one in the complex interaction between the two values and
having the cache be defeated. Could just put a +2 in the warning, I
guess? :/
s
ghost
mentioned this pull request
|
Reviewed-by: |
liewegas
pushed a commit
that referenced
this pull request
Jun 16, 2014
osd: add sanity check/warning on a few key configs Reviewed-by: Loic Dachary <loic@dachary.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warn when certain config values are set to bad values.
Backport: firefly, dumpling Signed-off-by: Sage Weil sage@inktank.com