common: stack overflow in JSONFormatter::print_quoted_string#19771
Closed
fangyuxiangGL wants to merge 1 commit intoceph:masterfrom
Closed
common: stack overflow in JSONFormatter::print_quoted_string#19771fangyuxiangGL wants to merge 1 commit intoceph:masterfrom
fangyuxiangGL wants to merge 1 commit intoceph:masterfrom
Conversation
Contributor
Author
|
could u have a look? thanks. |
fangyuxiangGL
force-pushed
the
segment-core
branch
from
e0d2e18 to
981d517
Compare
Contributor
|
@fangyuxiangGL this sounds like a fix we'll want to backport - could you please create a tracker issue? |
Fixes: http://tracker.ceph.com/issues/22567 Signed-off-by: fang yuxiang fang.yuxiang@eisoo.com
fangyuxiangGL
force-pushed
the
segment-core
branch
from
981d517 to
cce6480
Compare
Contributor
Author
|
@cbodley done. |
Contributor
|
@fangyuxiangGL i hadn't realized how bad these json/xml escape interfaces were. i opened a separate pr at #19806 that adds streaming interfaces that don't require this allocation. would you be willing to rework the Formatters to use those instead? |
Contributor
Author
|
ok, will do it! |
Contributor
Author
|
issue doesn't exist after #15599 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
one can reproduce by steps:
then radosgw-admin will coredump
Signed-off-by: fang yuxiang fang.yuxiang@eisoo.com