Merged
Conversation
Author
|
gitbuilder running |
added 6 commits
August 6, 2014 15:21
Add the ErasureCode base class for ErasureCodeJerasure and ErasureCodeIsa, for methods that can be shared among all plugins. http://tracker.ceph.com/issues/8496 Fixes: #8496 Signed-off-by: Loic Dachary <loic@dachary.org>
The bulk of ErasureCode{Jerasure,Isa}::encode and
ErasureCode{Jerasure,Isa}::decode is dealing with alignment and buffer
allocation. This is moved to ErasureCode::encode and ErasureCode::decode
respectively.
The jerasure/isa specific code is isolated in the new
ErasureCode{Jerasure,Isa}::encode_chunks and
ErasureCode{Jerasure,Isa}::decode_chunks virtual functions.
http://tracker.ceph.com/issues/8496 Refs: #8496
Signed-off-by: Loic Dachary <loic@dachary.org>
The ErasureCode{Jerasure,Isa}::minimum_to_decode and
ErasureCode{Jerasure,Isa}::minimum_to_decode_with_cost methods are moved
verbatim to the ErasureCode base class.
http://tracker.ceph.com/issues/8496 Refs: #8496
Signed-off-by: Loic Dachary <loic@dachary.org>
The parameter parser helpers to_int and to_bool are moved from
ErasureCode{Jerasure,Isa} to ErasureCode.
The prototype is modified to return a status instead of the value. An
error ostream is provided as the last argument because ErasureCode
cannot use dout() or derr().
http://tracker.ceph.com/issues/8496 Refs: #8496
Signed-off-by: Loic Dachary <loic@dachary.org>
It does not belong to ErasureCodeInterface which is supposed to not have any implementation. Signed-off-by: Loic Dachary <loic@dachary.org>
The ErasureCode::parse virtual function is derived in
ErasureCode{Jerasure,Isa}. It is reworked to share parsing arguments the
various techniques have in common. The logic is otherwise unmodified.
http://tracker.ceph.com/issues/8496 Refs: #8496
Signed-off-by: Loic Dachary <loic@dachary.org>
Author
|
@apeters1971 rebased and repushed. It is unmodified from the API point of view so you should not see any difference. I just removed the chunk mapping commits from the series because they were unrelated. |
ghost
changed the title
ghost
pushed a commit
that referenced
this pull request
Aug 10, 2014
erasure code base class Reviewed-by: Andreas-Joachim Peters <Andreas.Joachim.Peters@cern.ch>
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.