erasure-code: chunk remapping#2213
Merged
3 commits merged intomasterfrom Aug 15, 2014
unknown repository
Merged
Conversation
ghost
changed the title
Author
|
@athanatos would you have time to look at https://github.com/dachary/ceph/commit/27b51dfaee0f2c4caa448cbf1131e10edf522a77 ? And the rest of the commits also but they are straightforward ;) |
ghost
changed the title
Author
|
@athanatos https://github.com/dachary/ceph/commit/5f30d06f7edf23d4eb41ee154bf63e02400be7bc is ready for your review when you have time ;-) |
Author
|
rebased & repushed |
Contributor
|
Looks good to me once we've got a teuthology test which has been run. |
added 3 commits
August 15, 2014 01:07
Add support for erasure code plugins that do not sequentially map the chunks encoded to the corresponding index. This is mostly transparent to the caller, except when it comes to retrieving the data chunks when reading. For this purpose there needs to be a remapping function so the caller has a way to figure out which chunks actually contain the data and reorder them. Signed-off-by: Loic Dachary <loic@dachary.org>
Each D letter is a data chunk. For instance:
_DDD_DDD
is going to parse into:
[ 1, 2, 3, 5, 6, 7 ]
the 0 and 4 positions are not used by chunks and do not show in the
mapping. Implement ErasureCode::parse to support a reasonable default
for the mapping parameter.
Signed-off-by: Loic Dachary <loic@dachary.org>
If the remap vector is not empty, use it to figure out the sequence of data chunks. http://tracker.ceph.com/issues/9025 Fixes: #9025 Signed-off-by: Loic Dachary <loic@dachary.org>
ghost
pushed a commit
that referenced
this pull request
Aug 15, 2014
erasure-code: chunk remapping Reviewed-by: Samuel Just <sam.just@inktank.com>
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interpret the mapping parameter and remap the chunks accordingly. For instance mapping=DD means the data chunks are stored in the last two chunks and mapping=DD is the default where the data chunks are stored in the first two chunks for K=2, M=1