rpm: Install python3-tox on >= fedora 29

[badone]

Fix the error "No matching package to install: 'python-tox'"

Fixes: http://tracker.ceph.com/issues/37301

Signed-off-by: Brad Hubbard bhubbard@redhat.com

• References tracker ticket
• Updates documentation if necessary
• Includes tests for new functionality or reproducer for bug

[tchaikov]

strange enough, _python_buildid should be 3 in this case. as %{without python2} should be false on fedora by default.

[badone]

It's the logic in munge_ceph_spec_in I believe

[badone]

$ lsb_release -d
Description: Fedora release 29 (Twenty Nine)
$ type python2
python2 is /usr/bin/python2
$ echo $?
0

[badone]

@smithfarm could you take a look please?

[badone]

$ bash -x ./install-deps.sh                 
+ '[' -z '' ']'
...
 + type python2
 + sed -i -e 's/%bcond_with python2/%bcond_without python2/g' /tmp/install-deps.1540/ceph.spec
 + '[' ']'

[badone]

Is this what we need?

diff --git a/install-deps.sh b/install-deps.sh
index da22e54bba..35b0c255ba 100755
--- a/install-deps.sh
+++ b/install-deps.sh
@@ -35,7 +35,7 @@ function install_seastar_deps {
 function munge_ceph_spec_in {
     local OUTFILE=$1
     sed -e 's/@//g' -e 's/%bcond_with make_check/%bcond_without make_check/g' < ceph.spec.in > $OUTFILE
-    if type python2 > /dev/null 2>&1 ; then
+    if ! type python2 > /dev/null 2>&1 ; then
         sed -i -e 's/%bcond_with python2/%bcond_without python2/g' $OUTFILE
     else
         sed -i -e 's/%bcond_without python2/%bcond_with python2/g' $OUTFILE

[badone]

Nope, that doesn't work.

[tchaikov]

i think we should default to python3 (i.e., 's/%bcond_without python2/%bcond_with python2/g') on fedora 29, where python3 is dominant.

[badone]

I could create a special case in munge_ceph_spec_in for f29?

[tchaikov]

yeah. we can even skip this step if it's on f29.

[smithfarm]

In its unmunged form, the spec file will try to do a Python 3 build on Fedora. In other words, it will look for the python3-... form of all the python build deps (including tox).

However, as you already have zeroed in on, if install-deps.sh is being used, there is a twist. Inside install-deps.sh, there's a function munge_ceph_spec_in which tries to be clever. It looks at the system and if there is a python2 binary, it clobbers the python2 bcond in the spec file, unconditionally, to produce a Python 2 build.

However, if the system doesn't have the right repos providing all the py2 versions of the build dependencies, then the build will still fail.

Have you tried uninstalling Python 2 before running install-deps.sh?

[smithfarm]

Also, when looking at %bcond it's good to be aware that the meaning is non-intuitive:

%bcond_with foo means "foo is disabled by default"
%bcond_without foo means "foo is enabled by default"

WTF, you say? But actually it makes sense. The macro %bcond_with foo macro creates a --with-foo option to rpmbuild, and this necessarily implies that %bcond_with foo in the spec file means "foo is disabled by default".

For more info, see http://rpm.org/user_doc/conditional_builds.html

[smithfarm]

Please see #25181 for a different approach.

[badone]

👍