mon/MonClient: be less aggressive/paranoid about reopening mon connections#25902
Merged
liewegas merged 2 commits intoceph:masterfrom Jan 12, 2019
Merged
mon/MonClient: be less aggressive/paranoid about reopening mon connections#25902liewegas merged 2 commits intoceph:masterfrom
liewegas merged 2 commits intoceph:masterfrom
Conversation
…tions Previously we were reopening any time the name of our mon changed. That was pretty much every time, since we started out with names from the seed monmap like 'noname-[abc]' that never match the real mons. Instead, only reopen if the addr we are connecting to is no longer in the monmap. We don't actually care about the mon's name. Fixes: http://tracker.ceph.com/issues/37868 Signed-off-by: Sage Weil <sage@redhat.com>
…results This makes the test more strict and less confusing. Signed-off-by: Sage Weil <sage@redhat.com>
neha-ojha
changed the title
tchaikov
approved these changes
Jan 11, 2019
liewegas
added a commit
that referenced
this pull request
Jan 12, 2019
* refs/pull/25902/head: qa/standalone/mon/mon-handle-forward: fix grep path and check return results mon/MonClient: be less aggressive/paranoid about reopening mon connections Reviewed-by: Kefu Chai <kchai@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/37868