Skip to content

nautilus: mon/OSDMonitor: Use generic priority cache tuner for mon caches#29652

Closed
sseshasa wants to merge 3 commits intonautilusfrom
wip-40870-nautilus
Closed

nautilus: mon/OSDMonitor: Use generic priority cache tuner for mon caches#29652
sseshasa wants to merge 3 commits intonautilusfrom
wip-40870-nautilus

Conversation

@sseshasa
Copy link
Copy Markdown
Contributor

@sseshasa sseshasa commented Aug 14, 2019

Use priority cache manager to tune inc, full and rocksdb caches.

Fixes: #41238
Backport: nautilus
Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
(cherry picked from commit 3b96417)

Conflicts:
    src/mon/OSDMonitor.h
     removed unrelated declaration of pending_pseudo_purged_snaps map.
…sizes

Fixes: #41238
Backport: nautilus
Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
(cherry picked from commit e4d2364)
Fixes: #41238
Backport: nautilus
Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
(cherry picked from commit 1034782)
@sseshasa sseshasa added this to the nautilus milestone Aug 14, 2019
@sseshasa sseshasa self-assigned this Aug 14, 2019
@smithfarm
Copy link
Copy Markdown
Contributor

Build failure:

[ 38%] Building CXX object src/rgw/CMakeFiles/rgw_common.dir/rgw_keystone.cc.o
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/mon/MDSMonitor.cc:23:0:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/mon/OSDMonitor.h:231:34: error: 'Manager' is not a member of 'PriorityCache'
   std::shared_ptr<PriorityCache::Manager> pcm = nullptr;
                                  ^~~~~~~
/home/jenkins-build/build/workspace/ceph-pull-requests/src/mon/OSDMonitor.h:231:41: error: template argument 1 is invalid
   std::shared_ptr<PriorityCache::Manager> pcm = nullptr;
                                         ^
/home/jenkins-build/build/workspace/ceph-pull-requests/src/mon/OSDMonitor.h:231:49: error: cannot convert 'std::nullptr_t' to 'int' in initialization
   std::shared_ptr<PriorityCache::Manager> pcm = nullptr;
                                                 ^~~~~~~
src/mon/CMakeFiles/mon.dir/build.make:206: recipe for target 'src/mon/CMakeFiles/mon.dir/MDSMonitor.cc.o' failed
make[3]: *** [src/mon/CMakeFiles/mon.dir/MDSMonitor.cc.o] Error 1

@smithfarm smithfarm added the DNM label Aug 16, 2019
@sseshasa
Copy link
Copy Markdown
Contributor Author

This has a dependency on the latest changes of priority cache manager being available in nautilus. @markhpc @neha-ojha is there a corresponding backport created for #27381 and other subsequent improvements to pcm? I can add them as dependencies to this PR on the tracker ticket.

@neha-ojha
Copy link
Copy Markdown
Member

This has a dependency on the latest changes of priority cache manager being available in nautilus. @markhpc @neha-ojha is there a corresponding backport created for #27381 and other subsequent improvements to pcm? I can add them as dependencies to this PR on the tracker ticket.

I don't think so. Yeah, adding references to master PRs/commits should be fine.

@sseshasa
Copy link
Copy Markdown
Contributor Author

I will open a new branch to track this backport PR as there a lot more commits to be picked from master. Closing this PR.

@sseshasa sseshasa closed this Sep 16, 2019
@sseshasa sseshasa deleted the wip-40870-nautilus branch September 16, 2019 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants