log: fix timestap precision of log can't set to millisecond.#33720
Merged
tchaikov merged 1 commit intoceph:masterfrom Jun 9, 2020
Merged
log: fix timestap precision of log can't set to millisecond.#33720tchaikov merged 1 commit intoceph:masterfrom
tchaikov merged 1 commit intoceph:masterfrom
Conversation
The option log_coarse_timestamps can be set to Log::clock successfully,but the Log::clock has no effect on time accuracy because the dout_impl really use is Entry::clock.So we should set Entry::clock by log_coarse_timestamps option instead of Log:clock.In addition, i think the Log::clock can be removed because i didn't see what it was for. Fixes: https://tracker.ceph.com/issues/44409 Signed-off-by: Guan yunfei <yunfei.guan@xtaotech.com>
batrick
requested changes
Mar 5, 2020
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
Contributor
|
@adamemerson Pinging for review |
adamemerson
approved these changes
May 14, 2020
Contributor
|
jenkins test make check |
1 similar comment
Contributor
|
jenkins test make check |
Contributor
|
@batrick This has been approved by @adamemerson and it just passed "make check" as well. |
batrick
approved these changes
May 26, 2020
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
log: fix timestap precision of log can't set to millisecond.
The option log_coarse_timestamps can be set to Log::clock
successfully,but the Log::clock has no effect on time accuracy
because the dout_impl really use is Entry::clock.So we should
set Entry::clock by log_coarse_timestamps option instead of
Log:clock.In addition, i think the Log::clock can be removed
because i didn't see what it was for.
Fixes: https://tracker.ceph.com/issues/44409
Signed-off-by: Guan yunfei yunfei.guan@xtaotech.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox