Skip to content

mgr/dashboard: NoRebalance flag is added to the Dashboard#33862

Merged
LenzGr merged 1 commit intoceph:masterfrom
rhcs-dashboard:norebalance_flag_dashboard
Mar 11, 2020
Merged

mgr/dashboard: NoRebalance flag is added to the Dashboard#33862
LenzGr merged 1 commit intoceph:masterfrom
rhcs-dashboard:norebalance_flag_dashboard

Conversation

@nizamial09-zz
Copy link
Copy Markdown

@nizamial09-zz nizamial09-zz commented Mar 10, 2020

This PR will add a norebalance flag into the Cluster-wide Flags in the OSDs which can be set/unset.

Fixes: https://tracker.ceph.com/issues/44543
Signed-off-by: Nizamudeen nia@redhat.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@nizamial09-zz nizamial09-zz requested a review from a team as a code owner March 10, 2020 16:38
nizamial09-zz pushed a commit to rhcs-dashboard/ceph that referenced this pull request Mar 10, 2020
This commit will add a norebalance flag into the Cluster-wide Flags in the OSDs which can be set/unset.
Fixes: ceph#33862

Signed-off-by: Nizamudeen <nia@redhat.com>
@nizamial09-zz nizamial09-zz force-pushed the norebalance_flag_dashboard branch from 5a5233e to 0014431 Compare March 10, 2020 16:47
Copy link
Copy Markdown
Member

@epuertat epuertat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Besides the Fixes: placement issue already mentioned, I'm ok with it. Congrats for your first submission btw, Nizam!

This commit will add a norebalance flag into the Cluster-wide Flags in the OSDs which can be set/unset.
Fixes: https://tracker.ceph.com/issues/44543

Signed-off-by: Nizamudeen <nia@redhat.com>
@nizamial09-zz nizamial09-zz force-pushed the norebalance_flag_dashboard branch from 0014431 to 7e30c26 Compare March 10, 2020 16:52
@nizamial09-zz
Copy link
Copy Markdown
Author

Looks good! Besides the Fixes: placement issue already mentioned, I'm ok with it. Congrats for your first submission btw, Nizam!

Thank you :)

Copy link
Copy Markdown

@Devp00l Devp00l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm 👍

@LenzGr LenzGr merged commit bf6df4b into ceph:master Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants