librbd: make rbd_read_from_replica_policy actually work#35332
Merged
dillaman merged 1 commit intoceph:masterfrom Jun 1, 2020
Merged
librbd: make rbd_read_from_replica_policy actually work#35332dillaman merged 1 commit intoceph:masterfrom
dillaman merged 1 commit intoceph:masterfrom
Conversation
Commit d92be8b ("librbd: Improved support for balanced and localized reads") introduced read_flags, but used low-level Objecter flags (CEPH_OSD_FLAG_*). This is wrong because librbd sits on top of librados, not Objecter. "balance" ends up being translated into IGNORE_REDIRECT and "localize" being ignored. Fixes: https://tracker.ceph.com/issues/45798 Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit d92be8b ("librbd: Improved support for balanced and
localized reads") introduced read_flags, but used low-level Objecter
flags (CEPH_OSD_FLAG_*). This is wrong because librbd sits on top of
librados, not Objecter. "balance" ends up being translated into
IGNORE_REDIRECT and "localize" being ignored.
Fixes: https://tracker.ceph.com/issues/45798
Signed-off-by: Ilya Dryomov idryomov@gmail.com