mgr/prometheus: automatically discover RBD pools for stats gathering#35603
Merged
trociny merged 1 commit intoceph:masterfrom Jun 18, 2020
Merged
mgr/prometheus: automatically discover RBD pools for stats gathering#35603trociny merged 1 commit intoceph:masterfrom
trociny merged 1 commit intoceph:masterfrom
Conversation
Contributor
|
Just thinking. What if instead of adding the additional config option ( |
trociny
reviewed
Jun 16, 2020
Author
Yeah, we could do that. |
dillaman
force-pushed
the
wip-46034
branch
2 times, most recently
from
3747109 to
ff0c87b
Compare
To simplify configuration, the existing 'rbd_stats_pools' config option now accepts '*' as a wildcard for the pool and/or namespace portion of the <pool>[/<namespace>] spec. Fixes: https://tracker.ceph.com/issues/46034 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Author
|
Commit message updated |
Contributor
|
jenkins test dashboard backend |
This was referenced Aug 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To simplify configuration, the existing 'rbd_stats_pools' config option
now accepts '*' as a wildcard for the pool and/or namespace portion of
the
<pool>[/<namespace>]spec.Fixes: https://tracker.ceph.com/issues/46034
Signed-off-by: Jason Dillaman dillaman@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox