osdc/Journaler: do not call onsafe->complete() if onsafe is 0#36777
Merged
batrick merged 1 commit intoceph:masterfrom Aug 31, 2020
Merged
osdc/Journaler: do not call onsafe->complete() if onsafe is 0#36777batrick merged 1 commit intoceph:masterfrom
batrick merged 1 commit intoceph:masterfrom
Conversation
lxbsz
requested review from
batrick and
ukernel
and removed request for
ukernel
Fixes: https://tracker.ceph.com/issues/47125 Signed-off-by: Xiubo Li <xiubli@redhat.com>
ukernel
approved these changes
Aug 25, 2020
Member
|
How did you find this? |
batrick
approved these changes
Aug 25, 2020
Member
Author
Locally I have some notes about the issues that I have hit before which have no any log or clue. As I remembered when I was fixing some kclient bugs which I need to reboot the MDS daemon frequently, and hit a crash once. And yesterday I was trying to figuring out the possible reasons by reading the journal log code. And there is on case that could reproduce it by running the following steps: 1, Keep running the command The And also there are other cases will hit it. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/47125
Signed-off-by: Xiubo Li xiubli@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox