Number of degraded objects in EC pool is wrong when there is OSD down(in)#3726
Number of degraded objects in EC pool is wrong when there is OSD down(in)#3726guangyy wants to merge 1 commit intoceph:masterfrom guangyy:wip-4254
Conversation
|
SUCCESS: the output of run-make-check.sh on centos-centos7 for 89d5ca3 is http://paste2.org/_bYdcIH1d |
Sent from 
|
@guangyy could you please update the commit message with a short explanation about why it is wrong ? |
ghost
added
|
yes, looks good to me. a short(er) description would help. |
|
looks right to me! |
…(in) With EC pool (crush rule choose indep), when there is an OSD down, the size of the 'acting' list does not change (CRUSH_ITEM_NONE is used to replace the down OSD), in this case, 'actingset' should be used to calculate the degraded objects. Signed-off-by: Guang Yang <yguang@yahoo-inc.com>
|
@dachary , updated with a more descriptive commit message. |
|
@guangyy great, thanks. Would you mind opening a pull request targeted to hammer instead of master ? This is a bug fix that needs to go in hammer and it will later be merged in master. While you're at it, could you amend the commit message to start the subject with osd: ? Something like osd: number of degraded objects in EC pool is wrong when there is OSD down(in) |
|
SUCCESS: the output of run-make-check.sh on centos-centos7 for 2af596f is http://paste2.org/_EksgFcvG |
4 participants
For EC pool, actingset should be used instead of acting to calculate the number of degraded objects.
Signed-off-by: Guang Yang yguang@yahoo-inc.com